From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A341C7618F for ; Mon, 15 Jul 2019 18:06:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11952206B8 for ; Mon, 15 Jul 2019 18:06:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731964AbfGOSGs (ORCPT ); Mon, 15 Jul 2019 14:06:48 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40104 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729277AbfGOSGs (ORCPT ); Mon, 15 Jul 2019 14:06:48 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id DAF9914EB45A5; Mon, 15 Jul 2019 11:06:46 -0700 (PDT) Date: Mon, 15 Jul 2019 11:06:46 -0700 (PDT) Message-Id: <20190715.110646.1964036532467569670.davem@davemloft.net> To: huangfq.daxian@gmail.com Cc: jcliburn@gmail.com, chris.snook@gmail.com, michael.chan@broadcom.com, vishal@chelsio.com, fugang.duan@nxp.com, cooldavid@cooldavid.org, mlindner@marvell.com, stephen@networkplumber.org, tariqt@mellanox.com, saeedm@mellanox.com, leon@kernel.org, jiri@mellanox.com, idosch@mellanox.com, jdmason@kudzu.us, manishc@marvell.com, rahulv@marvell.com, GR-Linux-NIC-Dev@marvell.com, chessman@tux.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v3 17/24] ethernet: remove redundant memset From: David Miller In-Reply-To: <20190715031911.6982-1-huangfq.daxian@gmail.com> References: <20190715031911.6982-1-huangfq.daxian@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 15 Jul 2019 11:06:47 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fuqian Huang Date: Mon, 15 Jul 2019 11:19:11 +0800 > kvzalloc already zeroes the memory during the allocation. > pci_alloc_consistent calls dma_alloc_coherent directly. > In commit 518a2f1925c3 > ("dma-mapping: zero memory returned from dma_alloc_*"), > dma_alloc_coherent has already zeroed the memory. > So the memset after these function is not needed. > > Signed-off-by: Fuqian Huang Applied.