From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6326C76191 for ; Mon, 15 Jul 2019 15:14:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7AD702054F for ; Mon, 15 Jul 2019 15:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563203690; bh=k7KGx+ifK/KcZDOpWRw0+iwO8rI/RQKKC4SfwdiRjcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yd60GGg7czjk6/7uzJrxGsl6svWtsKeeU1713AwEwTCIV+mkuRGqasdSl2nj4m0Wh 6hD9Vmo8y2UwNgabWYJnx4r+TtkR5067NOUlOLwQs24AGk5MSdbP3br/biCShd48w3 0xUE94jUVRwnJlVMgQN+50rPp5qQTS9OZ8tkyUe4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731246AbfGONru (ORCPT ); Mon, 15 Jul 2019 09:47:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:57438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730773AbfGONrs (ORCPT ); Mon, 15 Jul 2019 09:47:48 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97FE520896; Mon, 15 Jul 2019 13:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563198468; bh=k7KGx+ifK/KcZDOpWRw0+iwO8rI/RQKKC4SfwdiRjcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jwLbsTV/oLjEWvr5MLRFMYWYr8TfRwa4fVnKhT8TLrZ98fZehKV9KxqMbR0QFmPv+ az+YIQ8y79Zki6PIBSsBfcFN2Bo3ethyIhjReHgpE8p3DMMftnrXccBBc9i5IvVe0X uomFNqnNrykdzGBfNOya1PM/qe3BL55biE+88lZM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jeremy Sowden , syzbot+d454a826e670502484b8@syzkaller.appspotmail.com, Simon Wunderlich , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.2 018/249] batman-adv: fix for leaked TVLV handler. Date: Mon, 15 Jul 2019 09:43:03 -0400 Message-Id: <20190715134655.4076-18-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715134655.4076-1-sashal@kernel.org> References: <20190715134655.4076-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jeremy Sowden [ Upstream commit 17f78dd1bd624a4dd78ed5db3284a63ee807fcc3 ] A handler for BATADV_TVLV_ROAM was being registered when the translation-table was initialized, but not unregistered when the translation-table was freed. Unregister it. Fixes: 122edaa05940 ("batman-adv: tvlv - convert roaming adv packet to use tvlv unicast packets") Reported-by: syzbot+d454a826e670502484b8@syzkaller.appspotmail.com Signed-off-by: Jeremy Sowden Signed-off-by: Sven Eckelmann Signed-off-by: Sasha Levin --- net/batman-adv/translation-table.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index 1ddfd5e011ee..8a482c5ec67b 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c @@ -3813,6 +3813,8 @@ static void batadv_tt_purge(struct work_struct *work) */ void batadv_tt_free(struct batadv_priv *bat_priv) { + batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_ROAM, 1); + batadv_tvlv_container_unregister(bat_priv, BATADV_TVLV_TT, 1); batadv_tvlv_handler_unregister(bat_priv, BATADV_TVLV_TT, 1); -- 2.20.1