From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A12A8C7618F for ; Mon, 15 Jul 2019 15:07:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 687E42054F for ; Mon, 15 Jul 2019 15:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563203263; bh=IY/4Z3VZKH9tWX8hyzz9JLXe2h+wlpamdpXgSSjSkGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FCtAw4NdL7PYVlY5nITJgVGh0CPkbPEEBXO5ExcFuwr9eTLFdEFz08W8TujTzz3Ak IRrfsi2Qvc6WNPp6ddt+KA1mjdNBF/kuJ9dKGVz5GZXHqjuh3hIOjQgnHDH3Ct4gZG joJLSgCozYvpb6hkLmqi4VZlcrJHhaq0vCWYYFj0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387554AbfGOOCH (ORCPT ); Mon, 15 Jul 2019 10:02:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:45050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730529AbfGOOCG (ORCPT ); Mon, 15 Jul 2019 10:02:06 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E0CB620C01; Mon, 15 Jul 2019 14:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563199325; bh=IY/4Z3VZKH9tWX8hyzz9JLXe2h+wlpamdpXgSSjSkGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J7K+2/Qf3oE9+v3WP+J3J4sWNB/Hw0bpOvB/yVSw2xxTxlQY9eSmIyKdGUU6LDGes 4eSx/3S8M4+b8VvdjpZhaq5Omb+BQc+esIixb+j0WlLxVXC/T71FQO2kfKqceqJ5OD MLQ8nN1Nji5DSkxRoF8MIwwnZURu7go4Ecu90jS4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jian Shen , Peng Li , Huazhong Tan , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.2 233/249] net: hns3: fix port capbility updating issue Date: Mon, 15 Jul 2019 09:46:38 -0400 Message-Id: <20190715134655.4076-233-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715134655.4076-1-sashal@kernel.org> References: <20190715134655.4076-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jian Shen [ Upstream commit 49b1255603de5183c5e377200be3b3afe0dcdb86 ] Currently, the driver queries the media port information, and updates the port capability periodically. But it sets an error mac->speed_type value, which stops update port capability. Fixes: 88d10bd6f730 ("net: hns3: add support for multiple media type") Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Huazhong Tan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c index bab04d2d674a..f2bffc05e902 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c @@ -2592,6 +2592,7 @@ static int hclge_get_sfp_info(struct hclge_dev *hdev, struct hclge_mac *mac) mac->speed_ability = le32_to_cpu(resp->speed_ability); mac->autoneg = resp->autoneg; mac->support_autoneg = resp->autoneg_ability; + mac->speed_type = QUERY_ACTIVE_SPEED; if (!resp->active_fec) mac->fec_mode = 0; else -- 2.20.1