From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC296C7618F for ; Mon, 15 Jul 2019 14:06:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7089206B8 for ; Mon, 15 Jul 2019 14:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563199618; bh=KEEMPSmzZBqvuzF0rBhmpLHTsuU/WTchaLqYwHks5Ag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OetonvXhdtCtNUm9mClDxau54MxeW3o8LgIAoLNpKKrZFzjpvWrgw7VeTW/Ybu0vM IgpiQY22uyxbopvGb7oL7aoCxXFwft/14bQyzJtsC0kCyAocv9ojbSGoxT7fNZ9oES NkoB+QtqHSJnxuu0OZVO5ERnzW7b3cCfw0Ku5wp0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388349AbfGOOG5 (ORCPT ); Mon, 15 Jul 2019 10:06:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:54882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388337AbfGOOG4 (ORCPT ); Mon, 15 Jul 2019 10:06:56 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E0326217D9; Mon, 15 Jul 2019 14:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563199615; bh=KEEMPSmzZBqvuzF0rBhmpLHTsuU/WTchaLqYwHks5Ag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uPdz6ub0aGkzSQJKmJ/e5yjeKRHdOHVxNa0fQsSqQnZAJ18wXD4aT9O9AQv17iodh /OWmCdmFaoZEWmzvMLZggH4zS80xFW6zOzobSJGz3E310RavSkXpk/0G4LY0RuQOSk Q/vR46QnbyWJZstAEsrS03+VMA2tEbIVEah0K5M0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Weihang Li , Peng Li , Huazhong Tan , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.1 056/219] net: hns3: set ops to null when unregister ad_dev Date: Mon, 15 Jul 2019 10:00:57 -0400 Message-Id: <20190715140341.6443-56-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715140341.6443-1-sashal@kernel.org> References: <20190715140341.6443-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Weihang Li [ Upstream commit 594a81b39525f0a17e92c2e0b167ae1400650380 ] The hclge/hclgevf and hns3 module can be unloaded independently, when hclge/hclgevf unloaded firstly, the ops of ae_dev should be set to NULL, otherwise it will cause an use-after-free problem. Fixes: 38caee9d3ee8 ("net: hns3: Add support of the HNAE3 framework") Signed-off-by: Weihang Li Signed-off-by: Peng Li Signed-off-by: Huazhong Tan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.c b/drivers/net/ethernet/hisilicon/hns3/hnae3.c index 17ab4f4af6ad..0da814618565 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hnae3.c +++ b/drivers/net/ethernet/hisilicon/hns3/hnae3.c @@ -247,6 +247,7 @@ void hnae3_unregister_ae_algo(struct hnae3_ae_algo *ae_algo) ae_algo->ops->uninit_ae_dev(ae_dev); hnae3_set_bit(ae_dev->flag, HNAE3_DEV_INITED_B, 0); + ae_dev->ops = NULL; } list_del(&ae_algo->node); @@ -347,6 +348,7 @@ void hnae3_unregister_ae_dev(struct hnae3_ae_dev *ae_dev) ae_algo->ops->uninit_ae_dev(ae_dev); hnae3_set_bit(ae_dev->flag, HNAE3_DEV_INITED_B, 0); + ae_dev->ops = NULL; } list_del(&ae_dev->node); -- 2.20.1