From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, edumazet@google.com
Subject: Re: [Patch net v2] net_sched: unset TCQ_F_CAN_BYPASS when adding filters
Date: Wed, 17 Jul 2019 12:04:46 -0700 (PDT) [thread overview]
Message-ID: <20190717.120446.101023323109287941.davem@davemloft.net> (raw)
In-Reply-To: <20190716205730.19675-1-xiyou.wangcong@gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Tue, 16 Jul 2019 13:57:30 -0700
> For qdisc's that support TC filters and set TCQ_F_CAN_BYPASS,
> notably fq_codel, it makes no sense to let packets bypass the TC
> filters we setup in any scenario, otherwise our packets steering
> policy could not be enforced.
...
Eric I think your feedback was addressed, please review to confirm.
Thank you.
next prev parent reply other threads:[~2019-07-17 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 20:57 [Patch net v2] net_sched: unset TCQ_F_CAN_BYPASS when adding filters Cong Wang
2019-07-17 19:04 ` David Miller [this message]
2019-07-17 19:19 ` Eric Dumazet
2019-07-17 20:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717.120446.101023323109287941.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).