From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Yqgg=VO=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B3475C7618F
	for <netdev@archiver.kernel.org>; Wed, 17 Jul 2019 19:04:48 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 91B6721849
	for <netdev@archiver.kernel.org>; Wed, 17 Jul 2019 19:04:48 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727057AbfGQTEr (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 17 Jul 2019 15:04:47 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:40948 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725993AbfGQTEr (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 17 Jul 2019 15:04:47 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 1726614766951;
        Wed, 17 Jul 2019 12:04:47 -0700 (PDT)
Date:   Wed, 17 Jul 2019 12:04:46 -0700 (PDT)
Message-Id: <20190717.120446.101023323109287941.davem@davemloft.net>
To:     xiyou.wangcong@gmail.com
Cc:     netdev@vger.kernel.org, edumazet@google.com
Subject: Re: [Patch net v2] net_sched: unset TCQ_F_CAN_BYPASS when adding
 filters
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190716205730.19675-1-xiyou.wangcong@gmail.com>
References: <20190716205730.19675-1-xiyou.wangcong@gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 17 Jul 2019 12:04:47 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Tue, 16 Jul 2019 13:57:30 -0700

> For qdisc's that support TC filters and set TCQ_F_CAN_BYPASS,
> notably fq_codel, it makes no sense to let packets bypass the TC
> filters we setup in any scenario, otherwise our packets steering
> policy could not be enforced.
 ...

Eric I think your feedback was addressed, please review to confirm.

Thank you.