From: David Miller <davem@davemloft.net>
To: brking@linux.vnet.ibm.com
Cc: GR-everest-linux-l2@marvell.com, skalluru@marvell.com,
aelior@marvell.com, netdev@vger.kernel.org
Subject: Re: [PATCH] bnx2x: Prevent load reordering in tx completion processing
Date: Thu, 18 Jul 2019 16:30:42 -0700 (PDT) [thread overview]
Message-ID: <20190718.163042.844837284595324517.davem@davemloft.net> (raw)
In-Reply-To: <1563226910-21660-1-git-send-email-brking@linux.vnet.ibm.com>
From: Brian King <brking@linux.vnet.ibm.com>
Date: Mon, 15 Jul 2019 16:41:50 -0500
> This patch fixes an issue seen on Power systems with bnx2x which results
> in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb
> pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons
> load in bnx2x_tx_int. Adding a read memory barrier resolves the issue.
>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
I agree with Brian's explanation of how the reordering can happen, and why
the crash doesn't show up in the prefetch() call.
I'll give the Marvell folks one more day to give a proper ACK.
Thanks.
next prev parent reply other threads:[~2019-07-18 23:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 21:41 [PATCH] bnx2x: Prevent load reordering in tx completion processing Brian King
2019-07-17 19:00 ` David Miller
2019-07-18 10:12 ` [EXT] " Manish Chopra
2019-07-18 18:26 ` Brian King
2019-07-18 23:30 ` David Miller [this message]
2019-07-21 19:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718.163042.844837284595324517.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=brking@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).