From: David Miller <davem@davemloft.net>
To: weiyongjun1@huawei.com
Cc: jcliburn@gmail.com, chris.snook@gmail.com,
o.rempel@pengutronix.de, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] ag71xx: fix return value check in ag71xx_probe()
Date: Thu, 18 Jul 2019 20:34:47 -0700 (PDT) [thread overview]
Message-ID: <20190718.203447.802057574398577206.davem@davemloft.net> (raw)
In-Reply-To: <20190719012206.100478-1-weiyongjun1@huawei.com>
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Fri, 19 Jul 2019 01:22:06 +0000
> In case of error, the function of_get_mac_address() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Applied.
prev parent reply other threads:[~2019-07-19 3:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 11:52 [PATCH] net: ag71xx: fix return value check in ag71xx_probe() Wei Yongjun
2019-07-18 7:39 ` Oleksij Rempel
2019-07-18 23:21 ` David Miller
2019-07-19 1:22 ` [PATCH v2] " Wei Yongjun
2019-07-19 3:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718.203447.802057574398577206.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chris.snook@gmail.com \
--cc=jcliburn@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).