From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9407CC76195 for ; Fri, 19 Jul 2019 06:38:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71D7720651 for ; Fri, 19 Jul 2019 06:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726642AbfGSGh6 (ORCPT ); Fri, 19 Jul 2019 02:37:58 -0400 Received: from mail.us.es ([193.147.175.20]:49714 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbfGSGh6 (ORCPT ); Fri, 19 Jul 2019 02:37:58 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 9A340C41B3 for ; Fri, 19 Jul 2019 08:37:54 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 8946D1150DD for ; Fri, 19 Jul 2019 08:37:54 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 7AB87A6A8; Fri, 19 Jul 2019 08:37:54 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3FEACDA732; Fri, 19 Jul 2019 08:37:52 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 19 Jul 2019 08:37:52 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [31.4.193.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 065A64265A31; Fri, 19 Jul 2019 08:37:51 +0200 (CEST) Date: Fri, 19 Jul 2019 08:37:49 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Jozsef Kadlecsik , Florian Westphal , Roopa Prabhu , Nikolay Aleksandrov , "David S. Miller" , wenxu , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net-next] netfilter: bridge: make NF_TABLES_BRIDGE tristate Message-ID: <20190719063749.45io5pxcxrlmrqqn@salvia> References: <20190710080835.296696-1-arnd@arndb.de> <20190718190110.akn54iwb2mui72cd@salvia> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="vq4lqf2by25ymvpi" Content-Disposition: inline In-Reply-To: <20190718190110.akn54iwb2mui72cd@salvia> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --vq4lqf2by25ymvpi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 18, 2019 at 09:01:10PM +0200, Pablo Neira Ayuso wrote: > On Wed, Jul 10, 2019 at 10:08:20AM +0200, Arnd Bergmann wrote: > > The new nft_meta_bridge code fails to link as built-in when NF_TABLES > > is a loadable module. > > > > net/bridge/netfilter/nft_meta_bridge.o: In function `nft_meta_bridge_get_eval': > > nft_meta_bridge.c:(.text+0x1e8): undefined reference to `nft_meta_get_eval' > > net/bridge/netfilter/nft_meta_bridge.o: In function `nft_meta_bridge_get_init': > > nft_meta_bridge.c:(.text+0x468): undefined reference to `nft_meta_get_init' > > nft_meta_bridge.c:(.text+0x49c): undefined reference to `nft_parse_register' > > nft_meta_bridge.c:(.text+0x4cc): undefined reference to `nft_validate_register_store' > > net/bridge/netfilter/nft_meta_bridge.o: In function `nft_meta_bridge_module_exit': > > nft_meta_bridge.c:(.exit.text+0x14): undefined reference to `nft_unregister_expr' > > net/bridge/netfilter/nft_meta_bridge.o: In function `nft_meta_bridge_module_init': > > nft_meta_bridge.c:(.init.text+0x14): undefined reference to `nft_register_expr' > > net/bridge/netfilter/nft_meta_bridge.o:(.rodata+0x60): undefined reference to `nft_meta_get_dump' > > net/bridge/netfilter/nft_meta_bridge.o:(.rodata+0x88): undefined reference to `nft_meta_set_eval' > > > > This can happen because the NF_TABLES_BRIDGE dependency itself is just a > > 'bool'. Make the symbol a 'tristate' instead so Kconfig can propagate the > > dependencies correctly. > > Hm. Something breaks here. Investigating. Looks like bridge support is > gone after this, nft fails to register the filter chain type: > > # nft add table bridge x > # nft add chain bridge x y { type filter hook input priority 0\; } > Error: Could not process rule: No such file or directory Found it. It seems this patch is needed, on top of your patch. I can just squash this chunk into your original patch and push it out if you're OK witht this. Thanks. --vq4lqf2by25ymvpi Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="x.patch" diff --git a/net/netfilter/nft_chain_filter.c b/net/netfilter/nft_chain_filter.c index 3fd540b2c6ba..b5d5d071d765 100644 --- a/net/netfilter/nft_chain_filter.c +++ b/net/netfilter/nft_chain_filter.c @@ -193,7 +193,7 @@ static inline void nft_chain_filter_inet_init(void) {} static inline void nft_chain_filter_inet_fini(void) {} #endif /* CONFIG_NF_TABLES_IPV6 */ -#ifdef CONFIG_NF_TABLES_BRIDGE +#if IS_ENABLED(CONFIG_NF_TABLES_BRIDGE) static unsigned int nft_do_chain_bridge(void *priv, struct sk_buff *skb, --vq4lqf2by25ymvpi--