From: David Miller <davem@davemloft.net>
To: navid.emamdoost@gmail.com
Cc: kjlu@umn.edu, smccaman@umn.edu, secalert@redhat.com,
emamd001@umn.edu, vishal@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] allocate_flower_entry: should check for null deref
Date: Sun, 21 Jul 2019 11:47:45 -0700 (PDT) [thread overview]
Message-ID: <20190721.114745.123875438153277101.davem@davemloft.net> (raw)
In-Reply-To: <20190721063731.7772-1-navid.emamdoost@gmail.com>
From: Navid Emamdoost <navid.emamdoost@gmail.com>
Date: Sun, 21 Jul 2019 01:37:31 -0500
> allocate_flower_entry does not check for allocation success, but tries
> to deref the result. I only moved the spin_lock under null check, because
> the caller is checking allocation's status at line 652.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Applied.
prev parent reply other threads:[~2019-07-21 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 6:37 [PATCH] allocate_flower_entry: should check for null deref Navid Emamdoost
2019-07-21 18:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190721.114745.123875438153277101.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=emamd001@umn.edu \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=secalert@redhat.com \
--cc=smccaman@umn.edu \
--cc=vishal@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox