From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6DE9C7618F for ; Mon, 22 Jul 2019 19:11:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8839F21901 for ; Mon, 22 Jul 2019 19:11:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731325AbfGVTLJ convert rfc822-to-8bit (ORCPT ); Mon, 22 Jul 2019 15:11:09 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:47978 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726432AbfGVTLI (ORCPT ); Mon, 22 Jul 2019 15:11:08 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7ECBC15258BA8; Mon, 22 Jul 2019 12:11:07 -0700 (PDT) Date: Mon, 22 Jul 2019 12:11:07 -0700 (PDT) Message-Id: <20190722.121107.493176692915633338.davem@davemloft.net> To: zenczykowski@gmail.com Cc: maze@google.com, netdev@vger.kernel.org, lorenzo@google.com, reminv@google.com, raorn@raorn.name Subject: Re: [PATCH] net-ipv6-ndisc: add support for RFC7710 RA Captive Portal Identifier From: David Miller In-Reply-To: <20190719063003.10684-1-zenczykowski@gmail.com> References: <20190719063003.10684-1-zenczykowski@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-2 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 Jul 2019 12:11:07 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Maciej Żenczykowski Date: Thu, 18 Jul 2019 23:30:03 -0700 > From: Maciej Żenczykowski > > This is trivial since we already have support for the entirely > identical (from the kernel's point of view) RDNSS and DNSSL that > also contain opaque data that needs to be passed down to userspace. > > As specified in RFC7710, Captive Portal option contains a URL. > 8-bit identifier of the option type as assigned by the IANA is 37. > This option should also be treated as userland. > > Hence, treat ND option 37 as userland (Captive Portal support) > > See: > https://tools.ietf.org/html/rfc7710 > https://www.iana.org/assignments/icmpv6-parameters/icmpv6-parameters.xhtml > > Fixes: e35f30c131a56 > Signed-off-by: Maciej Żenczykowski Applied to net-next.