From: Matthew Wilcox <willy@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: hch@lst.de, netdev@vger.kernel.org
Subject: Re: [PATCH v3 0/7] Convert skb_frag_t to bio_vec
Date: Mon, 22 Jul 2019 13:39:59 -0700 [thread overview]
Message-ID: <20190722203959.GH363@bombadil.infradead.org> (raw)
In-Reply-To: <20190712.112707.1312895410671986857.davem@davemloft.net>
On Fri, Jul 12, 2019 at 11:27:07AM -0700, David Miller wrote:
> From: Matthew Wilcox <willy@infradead.org>
> Date: Fri, 12 Jul 2019 06:43:38 -0700
>
> > From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> >
> > The skb_frag_t and bio_vec are fundamentally the same (page, offset,
> > length) tuple. This patch series unifies the two, leaving the
> > skb_frag_t typedef in place. This has the immediate advantage that
> > we already have iov_iter support for bvecs and don't need to add
> > support for iterating skbuffs. It enables a long-term plan to use
> > bvecs more broadly within the kernel and should make network-storage
> > drivers able to do less work converting between skbuffs and biovecs.
> >
> > It will consume more memory on 32-bit kernels. If that proves
> > problematic, we can look at ways of addressing it.
> >
> > v3: Rebase on latest Linus with net-next merged.
> > - Reorder the uncontroversial 'Use skb accessors' patches first so you
> > can apply just those two if you want to hold off on the full
> > conversion.
> > - Convert all the users of 'struct skb_frag_struct' to skb_frag_t.
>
> I have no objections to this series, please resubmit it (taking into
> consideration any more feedback you get) when net-next opens back
> up.
No further feedback received, and the patches still apply cleanly to
Linus' head. Do you want the patch series resent, or does your workflow
let you just pick these patches up now?
next prev parent reply other threads:[~2019-07-22 20:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 13:43 [PATCH v3 0/7] Convert skb_frag_t to bio_vec Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 1/7] net: Use skb accessors in network drivers Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 2/7] net: Use skb accessors in network core Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 3/7] net: Increase the size of skb_frag_t Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 4/7] net: Reorder the contents " Matthew Wilcox
2019-07-23 22:29 ` Saeed Mahameed
2019-07-24 1:28 ` Matthew Wilcox
2019-07-24 17:55 ` Saeed Mahameed
2019-07-12 13:43 ` [PATCH v3 5/7] net: Rename skb_frag page to bv_page Matthew Wilcox
2019-07-12 13:43 ` [PATCH v3 6/7] net: Rename skb_frag_t size to bv_len Matthew Wilcox
2019-07-23 22:33 ` Saeed Mahameed
2019-07-24 1:30 ` Matthew Wilcox
2019-07-24 17:58 ` Saeed Mahameed
2019-07-12 13:43 ` [PATCH v3 7/7] net: Convert skb_frag_t to bio_vec Matthew Wilcox
2019-07-12 18:27 ` [PATCH v3 0/7] " David Miller
2019-07-22 20:39 ` Matthew Wilcox [this message]
2019-07-22 20:45 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2019-07-23 3:08 Matthew Wilcox
2019-07-23 3:48 ` David Miller
2019-07-25 16:26 ` Jonathan Lemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722203959.GH363@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox