From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=/cpB=VU=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 1D81AC76186
	for <netdev@archiver.kernel.org>; Tue, 23 Jul 2019 23:05:45 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id E0A762238C
	for <netdev@archiver.kernel.org>; Tue, 23 Jul 2019 23:05:44 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726166AbfGWXFm (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Tue, 23 Jul 2019 19:05:42 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:38098 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726004AbfGWXFm (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 23 Jul 2019 19:05:42 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id C7C72153CC235;
        Tue, 23 Jul 2019 16:05:41 -0700 (PDT)
Date:   Tue, 23 Jul 2019 16:05:38 -0700 (PDT)
Message-Id: <20190723.160538.2065000079755912945.davem@davemloft.net>
To:     snelson@pensando.io
Cc:     netdev@vger.kernel.org
Subject: Re: [PATCH v4 net-next 02/19] ionic: Add hardware init and device
 commands
From:   David Miller <davem@davemloft.net>
In-Reply-To: <59e45fd2-3c62-58cf-cf63-935d17703d2c@pensando.io>
References: <20190722214023.9513-3-snelson@pensando.io>
        <20190723.141833.384334163321137202.davem@davemloft.net>
        <59e45fd2-3c62-58cf-cf63-935d17703d2c@pensando.io>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jul 2019 16:05:41 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Shannon Nelson <snelson@pensando.io>
Date: Tue, 23 Jul 2019 15:50:22 -0700

> On 7/23/19 2:18 PM, David Miller wrote:
>> From: Shannon Nelson <snelson@pensando.io>
>> Date: Mon, 22 Jul 2019 14:40:06 -0700
>>
>>> +void ionic_init_devinfo(struct ionic_dev *idev)
>>> +{
>>> + idev->dev_info.asic_type = ioread8(&idev->dev_info_regs->asic_type);
>>> + idev->dev_info.asic_rev = ioread8(&idev->dev_info_regs->asic_rev);
>>> +
>>> +	memcpy_fromio(idev->dev_info.fw_version,
>>> +		      idev->dev_info_regs->fw_version,
>>> +		      IONIC_DEVINFO_FWVERS_BUFLEN);
>>> +
>>> +	memcpy_fromio(idev->dev_info.serial_num,
>>> +		      idev->dev_info_regs->serial_num,
>>> +		      IONIC_DEVINFO_SERIAL_BUFLEN);
>>   ...
>>> +	sig = ioread32(&idev->dev_info_regs->signature);
>> I think if you are going to use the io{read,write}{8,16,32,64}()
>> interfaces then you should use io{read,write}{8,16,32,64}_rep()
>> instead of memcpy_{to,from}io().
>>
> Sure.

Note, I could be wrong.  Please test.

I think the operation of the two things might be different.