netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: kbuild-all@01.org, Martin Weinelt <martin@linuxlounge.net>,
	bridge@lists.linux-foundation.org,
	Roopa Prabhu <roopa@cumulusnetworks.com>,
	netdev@vger.kernel.org
Subject: [PATCH] fix noderef.cocci warnings
Date: Wed, 24 Jul 2019 06:54:58 +0800	[thread overview]
Message-ID: <20190723225458.GA3376@lkp-kbuild04> (raw)
In-Reply-To: <908e9e90-70cc-7bbe-f83f-0810c9ef3925@cumulusnetworks.com>

From: kbuild test robot <lkp@intel.com>

net/bridge/br_multicast.c:999:8-14: ERROR: application of sizeof to pointer

 sizeof when applied to a pointer typed expression gives the size of
 the pointer

Generated by: scripts/coccinelle/misc/noderef.cocci

Fixes: 17c91348ed8b ("Use-after-free in br_multicast_rcv")
CC: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-mcast-fix-possible-uses-of-stale-pointers/20190702-083354

 br_multicast.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -996,7 +996,7 @@ static int br_ip6_multicast_mld2_report(
 			return -EINVAL;
 
 		_nsrcs = skb_header_pointer(skb, nsrcs_offset,
-					   sizeof(_nsrcs), &__nsrcs);
+					   sizeof(*_nsrcs), &__nsrcs);
 		if (!_nsrcs)
 			return -EINVAL;
 

  parent reply	other threads:[~2019-07-23 22:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <41ac3aa3-cbf7-1b7b-d847-1fb308334931@linuxlounge.net>
     [not found] ` <E0170D52-C181-4F0F-B5F8-F1801C2A8F5A@cumulusnetworks.com>
2019-06-29 13:23   ` Use-after-free in br_multicast_rcv Martin Weinelt
2019-07-01 16:53   ` Martin Weinelt
2019-07-01 17:03     ` Nikolay Aleksandrov
2019-07-01 17:31       ` Martin Weinelt
2019-07-01 17:37         ` Nikolay Aleksandrov
2019-07-01 22:17           ` Martin Weinelt
2019-07-01 22:37             ` Nikolay Aleksandrov
2019-07-02  8:46               ` Martin Weinelt
2019-07-02  3:33           ` [PATCH TEST] net: bridge: mcast: fix possible uses of stale pointers kbuild test robot
2019-07-02  3:33           ` [PATCH] fix noderef.cocci warnings kbuild test robot
2019-07-23 22:54           ` [PATCH TEST] net: bridge: mcast: fix possible uses of stale pointers kbuild test robot
2019-07-23 22:54           ` kbuild test robot [this message]
2019-07-23 23:21             ` [PATCH] fix noderef.cocci warnings Nikolay Aleksandrov
2019-08-08 15:10           ` [PATCH TEST] net: bridge: mcast: fix possible uses of stale pointers kbuild test robot
2019-08-08 15:10           ` [PATCH] fix noderef.cocci warnings kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190723225458.GA3376@lkp-kbuild04 \
    --to=lkp@intel.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=kbuild-all@01.org \
    --cc=martin@linuxlounge.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).