From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA88C76194 for ; Wed, 24 Jul 2019 17:23:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1DEF822387 for ; Wed, 24 Jul 2019 17:23:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="YeeC3awk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728667AbfGXRX3 (ORCPT ); Wed, 24 Jul 2019 13:23:29 -0400 Received: from mx3.wp.pl ([212.77.101.9]:55270 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728590AbfGXRX0 (ORCPT ); Wed, 24 Jul 2019 13:23:26 -0400 Received: (wp-smtpd smtp.wp.pl 30481 invoked from network); 24 Jul 2019 19:16:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1563988604; bh=z41DzGtUFzaWWcpQAVjI+8rAtK/VXbLYrGHn+dMjo3I=; h=From:To:Cc:Subject; b=YeeC3awkT/FVcvjk+fURFqdyv0r3NGECJaqSruBjt2MEMxHyXyddFZaA64nkaxrka 0lLpbm0O7VZrCjgigBSnZ19v6fCSXRbOMwIZThg3hxH5pulTydVwW1xI4EtrctTXRp wUor382uyQhCqpSoEE8V8sOX195Tb9e+kJQh7ApQ= Received: from 014.152-60-66-biz-static.surewest.net (HELO cakuba.netronome.com) (kubakici@wp.pl@[66.60.152.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 24 Jul 2019 19:16:43 +0200 Date: Wed, 24 Jul 2019 10:16:36 -0700 From: Jakub Kicinski To: Navid Emamdoost Cc: kvalo@codeaurora.org, emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu, secalert@redhat.com, "David S. Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt7601u: null check the allocation Message-ID: <20190724101636.4699c30a@cakuba.netronome.com> In-Reply-To: <20190724141736.29994-1-navid.emamdoost@gmail.com> References: <87d0i00z4t.fsf@kamboji.qca.qualcomm.com> <20190724141736.29994-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: fe13a5d9e194338bda75b16965620f67 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [QTPk] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 24 Jul 2019 09:17:36 -0500, Navid Emamdoost wrote: > devm_kzalloc may fail and return NULL. So the null check is needed. > > Signed-off-by: Navid Emamdoost Ah, I replied to the wrong one.. Acked-by: Jakub Kicinski