From: Matthew Wilcox <willy@infradead.org>
To: Qian Cai <cai@lca.pw>
Cc: davem@davemloft.net, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] net/ixgbevf: fix a compilation error of skb_frag_t
Date: Wed, 24 Jul 2019 06:59:03 -0700 [thread overview]
Message-ID: <20190724135903.GU363@bombadil.infradead.org> (raw)
In-Reply-To: <1563975157-30691-1-git-send-email-cai@lca.pw>
On Wed, Jul 24, 2019 at 09:32:37AM -0400, Qian Cai wrote:
> for (f = 0; f < skb_shinfo(skb)->nr_frags; f++)
> - count += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].size);
> + count += TXD_USE_COUNT(skb_shinfo(skb)->frags[f].bv_len);
> #else
No, this is the wrong fix. Use the fine accessor instead:
+ count += TXD_USE_COUNT(skb_frag_size(&skb_shinfo(skb)->frags[f]));
although now there's a line length problem. Most drivers do:
skb_frag_t frag = &skb_shinfo(skb)->frags[f];
count += TXD_USE_COUNT(skb_frag_size(frag));
next prev parent reply other threads:[~2019-07-24 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 13:32 [PATCH -next] net/ixgbevf: fix a compilation error of skb_frag_t Qian Cai
2019-07-24 13:59 ` Matthew Wilcox [this message]
2019-07-24 22:02 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724135903.GU363@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=cai@lca.pw \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox