From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5564C76190 for ; Thu, 25 Jul 2019 18:53:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8CC921901 for ; Thu, 25 Jul 2019 18:53:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726514AbfGYSxs (ORCPT ); Thu, 25 Jul 2019 14:53:48 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37180 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726107AbfGYSxs (ORCPT ); Thu, 25 Jul 2019 14:53:48 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0D1FE143986A8; Thu, 25 Jul 2019 11:53:48 -0700 (PDT) Date: Thu, 25 Jul 2019 11:53:47 -0700 (PDT) Message-Id: <20190725.115347.1639559656820873202.davem@davemloft.net> To: chris.packham@alliedtelesis.co.nz Cc: madalin.bucur@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fsl/fman: Remove comment referring to non-existent function From: David Miller In-Reply-To: <20190723233501.6626-1-chris.packham@alliedtelesis.co.nz> References: <20190723233501.6626-1-chris.packham@alliedtelesis.co.nz> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 25 Jul 2019 11:53:48 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Chris Packham Date: Wed, 24 Jul 2019 11:35:01 +1200 > fm_set_max_frm() existed in the Freescale SDK as a callback for an > early_param. When this code was ported to the upstream kernel the > early_param was converted to a module_param making the reference to the > function incorrect. The rest of the comment already does a good job of > explaining the parameter so removing the reference to the non-existent > function seems like the best thing to do. > > Signed-off-by: Chris Packham Applied, thanks.