From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AD6BC7618B for ; Thu, 25 Jul 2019 10:04:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00B282190F for ; Thu, 25 Jul 2019 10:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564049086; bh=TEJk53LHFO9Ue4RAaS8/6tEcNjmL/kiPAgdMSNvmHdM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=P8F2wAksiGFNZVAZ81bLszGkeZs2mzrgvCUmp/cYcMNO6qCjVRXOtlxAtN0HU8ggB eqWf8v0H8eUyPl/jpHkS9Tv7CW0fjxxR+ftEKr+ETAF9tknZrUQe914cY3annWdqq5 KiPj2BM/VuRUqZ/ue1E2a5Kt/sVbSvkAEZAKYOcs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729056AbfGYKEp (ORCPT ); Thu, 25 Jul 2019 06:04:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:39474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725852AbfGYKEo (ORCPT ); Thu, 25 Jul 2019 06:04:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B39ED218D4; Thu, 25 Jul 2019 10:04:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564049083; bh=TEJk53LHFO9Ue4RAaS8/6tEcNjmL/kiPAgdMSNvmHdM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ywOOCxlu9NVt8/6cvytroviqXr15X52BbHOkT2Jx1tZ2imneLkIIzx61dTfnGd0bC BUzK1D2J5CDqmn8prpJFUCgjUG8R6McaXGYzqGh9hoVjueOfeYqB0YxfuVGEkVcmsb F+2knwpqkK8Z+yjlzjTsmO2ZGaQ1Fh6JkSdMZnJY= Date: Thu, 25 Jul 2019 12:04:40 +0200 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: Linus Walleij , netdev , linux-serial@vger.kernel.org, Thomas Gleixner , "David S. Miller" , Sascha Hauer , Michael Trensch , Robert Schwebel , Jiri Slaby , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/3] serial: remove netx serial driver Message-ID: <20190725100440.GC20445@kroah.com> References: <20190722191552.252805-1-arnd@arndb.de> <20190722191552.252805-2-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 23, 2019 at 10:43:05AM +0200, Arnd Bergmann wrote: > On Tue, Jul 23, 2019 at 10:26 AM Linus Walleij wrote: > > > > On Mon, Jul 22, 2019 at 9:16 PM Arnd Bergmann wrote: > > > > > The netx platform got removed, so this driver is now > > > useless. > > > > > > Signed-off-by: Arnd Bergmann > > > > We seem so overlap :) > > https://marc.info/?l=linux-serial&m=156377843325488&w=2 > > > > Anyways, the patches are identical except here: > > > > > -/* Hilscher netx */ > > > +/* Hilscher netx (removed) */ > > > #define PORT_NETX 71 > > > > Is there some reason for keeping the magical number around? > > When I looked over the file there seemed to be more "holes" > > in the list. > > I looked at the same list and though I saw more obsolete entries > than holes. The last ones that I saw getting removed were > PORT_MFD in 2017 and PORT_V850E_UART in 2008. > > It probably doesn't matter as we have precedence for both. I want to just get rid of that whole list as I don't think it's ever needed, but haven't spent the time digging through userspace code to verify it. I'll take Linus's patch as it came first, thanks. greg k-h