From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B542BC76190 for ; Thu, 25 Jul 2019 20:48:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 789F5218DA for ; Thu, 25 Jul 2019 20:48:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="UnYwlh3b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726529AbfGYUse (ORCPT ); Thu, 25 Jul 2019 16:48:34 -0400 Received: from mail-qt1-f170.google.com ([209.85.160.170]:42823 "EHLO mail-qt1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726473AbfGYUse (ORCPT ); Thu, 25 Jul 2019 16:48:34 -0400 Received: by mail-qt1-f170.google.com with SMTP id h18so50455700qtm.9 for ; Thu, 25 Jul 2019 13:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=ptUKGVoRRU8o1lCU6dbae1IctfrFFlzDr53AZzldROE=; b=UnYwlh3bFEgZ7RGMIqgOE/BevyyMheoLsPHAR6werjSpyyDJTlE7k2vsjg8lLzoPKx sZSVDnwK52/GM/kSdws1xLckOWVqL0RK0Yzwh28NhiUjSWuobma51XjjsvgMO+qXxAJT IJxJBLLtoiD2rcCegQw4DoCYM3eiN5rvkMck6ABRGA2M9x5jjomGDM3UBIFiKC9DRWSi LoqW9A5tXbp15kfDf5o34e9RpkEUVHUisMcjHX2ZeqeqA2bRM/CPSAZL93QaUBhCn4wR qlJWU8l0aN4DMx8rUUaSQBsyzL3KheXX8ARBCE9ZFv5tq1Q4zxZHpzfVsWUJDtIU+5VU +okA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=ptUKGVoRRU8o1lCU6dbae1IctfrFFlzDr53AZzldROE=; b=pWNVCYEGv39r3OhuvY8naD4QOwTZ1Uao5l+9t5JGPvFMjFksG1/NSwIRTdf7GuoRwt 0F7uzbTdt+RtNSgVWcbd3+rq5/lxToT03pt/WSU6FnRb9f9NPbiEVN3c06k3OsIf7LlO 1I+GgYA7W1BYHijb/0INfjyYtnMjN3pjPSM4BNykJj19vs79ilOYWG1mS3KYTttXfXm7 vQJZ+Ym56Zc4X7KjJIW/ltaOWMtvqjfWKkrZcEz0NEzHlYR2RFKP8xeBwWq4m2Mt1vJZ lzGXNTqIZFyt1C/G4BjpMSSPYGjNbesrtIA4Z2Qt/cNQe4Stb77SgiPWBGZzG4w8b+Qp YiZQ== X-Gm-Message-State: APjAAAVPuOrOyddg9lg0x5zSJtngtT1l0S/pCdTyApXtN5smL0khJrgn T732lYo8zIBwGMOfu6DD+1ZSDg== X-Google-Smtp-Source: APXvYqzKsXObXgP3VPjR0wUbKaBbY9NBI4qvyoWbmIYHy+DonXFnYdx+ZdQBy0BRLTnvUu306yOYsg== X-Received: by 2002:ac8:2b62:: with SMTP id 31mr64119710qtv.140.1564087713173; Thu, 25 Jul 2019 13:48:33 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id l6sm21389370qkc.89.2019.07.25.13.48.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 25 Jul 2019 13:48:33 -0700 (PDT) Date: Thu, 25 Jul 2019 13:48:28 -0700 From: Jakub Kicinski To: Saeed Mahameed Cc: "David S. Miller" , "netdev@vger.kernel.org" , Tariq Toukan Subject: Re: [net 7/9] net/mlx5e: kTLS, Call WARN_ONCE on netdev mismatch Message-ID: <20190725134828.1c56e467@cakuba.netronome.com> In-Reply-To: <20190725203618.11011-8-saeedm@mellanox.com> References: <20190725203618.11011-1-saeedm@mellanox.com> <20190725203618.11011-8-saeedm@mellanox.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 25 Jul 2019 20:36:48 +0000, Saeed Mahameed wrote: > From: Tariq Toukan > > A netdev mismatch in the processed TLS SKB should not occur, > and indicates a kernel bug. > Add WARN_ONCE to spot such cases. > > Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support") > Suggested-by: Jakub Kicinski > Signed-off-by: Tariq Toukan > Signed-off-by: Saeed Mahameed Acked-by: Jakub Kicinski