From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF75AC76190 for ; Thu, 25 Jul 2019 20:49:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 83693218DA for ; Thu, 25 Jul 2019 20:49:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="dwdQ8Sm3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbfGYUtz (ORCPT ); Thu, 25 Jul 2019 16:49:55 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:43205 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726473AbfGYUtz (ORCPT ); Thu, 25 Jul 2019 16:49:55 -0400 Received: by mail-qt1-f196.google.com with SMTP id w17so6139421qto.10 for ; Thu, 25 Jul 2019 13:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=Zd2owx10a1oRsdUwqqqh4UaszeFT1IFkoqvOxOfoBzY=; b=dwdQ8Sm3FyxGqKvlXEbJxxfgEnBn3rbCuzbIOx/CogaLrGdxdEXQMWzQjXui44qfv3 vOu6GXWeAO1bsaGWQPPBdi2xIfQbpcNXiVYDK7OJG/C0P3Rzwl6hTtHTdGF9I8i9JUu1 iOga0BQeoQ4F2YLB22vP/Z/LU6FOQh4u45Z1Gp5+qmG+xGBkoAZTr08Wd3Y/JyESxq/b lpI84xCssNXV2GHlkQH5LQApJqcFMWJZmAjAwkWC0xXHRvUFFiX+Wi7DCEVtRy1kRsuv U4SD6B7k/il33KBoW/OxZBW6lAN8vev85e2JC3d1hX2L6FNHFwWpfzHGrpwkJNPBtE3M /KOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=Zd2owx10a1oRsdUwqqqh4UaszeFT1IFkoqvOxOfoBzY=; b=Hayys2YK/6DpzDXx/ART4wBW9ejdsf2oNt2E5rb2d+rv9o6pI+NGywBwHqslnVwMrc b+7WQ+W1NHpBCPkDb8epTVTpZKtOL0ZSe+CHVkX0nc9+Z/giK16ey/aJqB41qQgo4Ay5 kxQYrTYXWeqJMNx5l02+vJsBb9gx2BFBVlotEKScQRLvJ6EXKx+ye3K5N9bdQFm12fho v30dFEv1dgU20YkJAWG9m2PmJhU8gQ0iRBwPpxgiOahcMA29ufx2Zpng4fpyJTyJlz6j xlyGqzbZtP4Jl0EjJYbg6jetZcKFmtqRYL1V8cZTL5nqkAj9+hLcj+2wJo0W3s3kCZYQ VU1A== X-Gm-Message-State: APjAAAUYF7qVr+7E/sKTwLNeovc2qopxvB/0Quhc2cjBIi8AL+IMj3zu PDkRYYqOu+uEraYKUKrX165LJAh4ZZo= X-Google-Smtp-Source: APXvYqziHglK/ki0SKUYI1ssmgy6IE2GyTw4treRm+36ycev2YAGSF5CFViCIoKe/+wmmwDM1nmzzQ== X-Received: by 2002:a0c:c3c7:: with SMTP id p7mr34699770qvi.125.1564087794268; Thu, 25 Jul 2019 13:49:54 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id o33sm23280299qtd.72.2019.07.25.13.49.53 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 25 Jul 2019 13:49:54 -0700 (PDT) Date: Thu, 25 Jul 2019 13:49:50 -0700 From: Jakub Kicinski To: Saeed Mahameed Cc: "David S. Miller" , "netdev@vger.kernel.org" , Tariq Toukan Subject: Re: [net 7/9] net/mlx5e: kTLS, Call WARN_ONCE on netdev mismatch Message-ID: <20190725134950.74733e62@cakuba.netronome.com> In-Reply-To: <20190725203618.11011-8-saeedm@mellanox.com> References: <20190725203618.11011-1-saeedm@mellanox.com> <20190725203618.11011-8-saeedm@mellanox.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 25 Jul 2019 20:36:48 +0000, Saeed Mahameed wrote: > From: Tariq Toukan > > A netdev mismatch in the processed TLS SKB should not occur, > and indicates a kernel bug. > Add WARN_ONCE to spot such cases. > > Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support") > Suggested-by: Jakub Kicinski > Signed-off-by: Tariq Toukan > Signed-off-by: Saeed Mahameed > --- > drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c > index ea032f54197e..3766545ce259 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c > @@ -412,7 +412,7 @@ struct sk_buff *mlx5e_ktls_handle_tx_skb(struct net_device *netdev, > goto out; > > tls_ctx = tls_get_ctx(skb->sk); > - if (unlikely(tls_ctx->netdev != netdev)) > + if (unlikely(WARN_ON_ONCE(tls_ctx->netdev != netdev))) Ah, nit: the unlikely is probably unnecessary but that's no big deal. #define WARN_ON_ONCE(condition) ({ \ static int __warned; \ int __ret_warn_once = !!(condition); \ \ if (unlikely(__ret_warn_once && !__warned)) { \ __warned = true; \ WARN_ON(1); \ } \ unlikely(__ret_warn_once); \ }) > goto err_out; > > priv_tx = mlx5e_get_ktls_tx_priv_ctx(tls_ctx);