From: Andrew Lunn <andrew@lunn.ch>
To: Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, Tristram Ha <Tristram.Ha@microchip.com>,
"David S . Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>
Subject: Re: [PATCH 3/3] net: dsa: ksz: Add Microchip KSZ8795 DSA driver
Date: Thu, 25 Jul 2019 16:03:51 +0200 [thread overview]
Message-ID: <20190725140351.GG21952@lunn.ch> (raw)
In-Reply-To: <20190724134048.31029-4-marex@denx.de>
On Wed, Jul 24, 2019 at 03:40:48PM +0200, Marek Vasut wrote:
> From: Tristram Ha <Tristram.Ha@microchip.com>
> +static void ksz8795_phy_setup(struct ksz_device *dev, int port,
> + struct phy_device *phy)
> +{
> + if (port < dev->phy_port_cnt) {
> + /*
> + * SUPPORTED_Asym_Pause and SUPPORTED_Pause can be removed to
> + * disable flow control when rate limiting is used.
> + */
> + linkmode_copy(phy->advertising, phy->supported);
> + }
> +}
Hi Marek
Do you know why this is needed?
Thanks
Andrew
next prev parent reply other threads:[~2019-07-25 14:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 13:40 [PATCH 0/3] net: dsa: ksz: Add Microchip KSZ87xx support Marek Vasut
2019-07-24 13:40 ` [PATCH 1/3] dt-bindings: net: dsa: ksz: document Microchip KSZ87xx family switches Marek Vasut
2019-07-24 13:40 ` [PATCH 2/3] net: dsa: ksz: Add KSZ8795 tag code Marek Vasut
2019-07-24 13:40 ` [PATCH 3/3] net: dsa: ksz: Add Microchip KSZ8795 DSA driver Marek Vasut
2019-07-24 21:46 ` David Miller
2019-07-25 14:03 ` Andrew Lunn [this message]
2019-07-25 14:56 ` Marek Vasut
2019-07-25 14:59 ` Andrew Lunn
2019-07-25 15:36 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725140351.GG21952@lunn.ch \
--to=andrew@lunn.ch \
--cc=Tristram.Ha@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).