From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "tanhuazhong@huawei.com" <tanhuazhong@huawei.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"liuyonglong@huawei.com" <liuyonglong@huawei.com>,
"lipeng321@huawei.com" <lipeng321@huawei.com>,
"yisen.zhuang@huawei.com" <yisen.zhuang@huawei.com>,
"salil.mehta@huawei.com" <salil.mehta@huawei.com>,
"linuxarm@huawei.com" <linuxarm@huawei.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 07/11] net: hns3: adds debug messages to identify eth down cause
Date: Thu, 25 Jul 2019 18:28:46 -0700 [thread overview]
Message-ID: <20190725182846.253ae93f@cakuba.netronome.com> (raw)
In-Reply-To: <75a02bbe5b3b0f2755cd901a8830d4a3026f9383.camel@mellanox.com>
On Thu, 25 Jul 2019 21:59:08 +0000, Saeed Mahameed wrote:
> I couldn't find any rules regarding what to put in kernel log, Maybe
> someone can share ?. but i vaguely remember that the recommendation
> for device drivers is to put nothing, only error/warning messages.
FWIW my understanding is also that only error/warning messages should
be printed. IOW things which should "never happen".
There are some historical exceptions. Probe logs for instance may be
useful, because its not trivial to get to the device if probe fails.
Another one is ethtool flashing, if it takes time we used to print into
logs some message like "please wait patiently". But since Jiri added
the progress messages in devlink that's no longer necessary.
For the messages which are basically printing the name of the function
or name of the function and their args - we have ftrace.
That's my $0.02 :)
next prev parent reply other threads:[~2019-07-26 1:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 3:18 [PATCH net-next 00/11] net: hns3: some code optimizations & bugfixes & features Huazhong Tan
2019-07-24 3:18 ` [PATCH net-next 01/11] net: hns3: add reset checking before set channels Huazhong Tan
2019-07-24 3:18 ` [PATCH net-next 02/11] net: hns3: add a check for get_reset_level Huazhong Tan
2019-07-24 3:18 ` [PATCH net-next 03/11] net: hns3: remove upgrade reset level when reset fail Huazhong Tan
2019-07-24 3:18 ` [PATCH net-next 04/11] net: hns3: fix mis-counting IRQ vector numbers issue Huazhong Tan
2019-07-24 18:28 ` Saeed Mahameed
2019-07-25 2:04 ` tanhuazhong
2019-07-24 3:18 ` [PATCH net-next 05/11] net: hns3: change GFP flag during lock period Huazhong Tan
2019-07-24 3:18 ` [PATCH net-next 06/11] net: hns3: modify firmware version display format Huazhong Tan
2019-07-24 18:34 ` Saeed Mahameed
2019-07-25 2:34 ` tanhuazhong
2019-07-25 21:32 ` Saeed Mahameed
2019-07-26 1:50 ` tanhuazhong
2019-07-24 3:18 ` [PATCH net-next 07/11] net: hns3: adds debug messages to identify eth down cause Huazhong Tan
2019-07-24 19:12 ` Saeed Mahameed
2019-07-25 12:28 ` liuyonglong
2019-07-25 21:59 ` Saeed Mahameed
2019-07-26 1:28 ` Jakub Kicinski [this message]
2019-07-26 2:33 ` liuyonglong
2019-07-26 2:21 ` liuyonglong
2019-07-24 3:18 ` [PATCH net-next 08/11] net: hns3: add interrupt affinity support for misc interrupt Huazhong Tan
2019-07-24 19:24 ` Saeed Mahameed
2019-07-25 2:05 ` Yunsheng Lin
2019-07-26 23:18 ` Saeed Mahameed
2019-07-29 10:17 ` Yunsheng Lin
2019-07-29 9:18 ` Salil Mehta
2019-07-29 10:37 ` Yunsheng Lin
2019-07-24 3:18 ` [PATCH net-next 09/11] net: hns3: make hclge_service use delayed workqueue Huazhong Tan
2019-07-24 3:18 ` [PATCH net-next 10/11] net: hns3: Add support for using order 1 pages with a 4K buffer Huazhong Tan
2019-07-24 3:18 ` [PATCH net-next 11/11] net: hns3: add support for handling IMP error Huazhong Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725182846.253ae93f@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=salil.mehta@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).