From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Clément Perrochaud" <clement.perrochaud@effinnov.com>,
"Charles Gorand" <charles.gorand@effinnov.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
"Sedat Dilek" <sedat.dilek@credativ.de>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: [PATCH v3 05/14] NFC: nxp-nci: Add GPIO ACPI mapping table
Date: Thu, 25 Jul 2019 22:35:02 +0300 [thread overview]
Message-ID: <20190725193511.64274-5-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20190725193511.64274-1-andriy.shevchenko@linux.intel.com>
In order to unify GPIO resource request prepare gpiod_get_index()
to behave correctly when there is no mapping provided by firmware.
Here we add explicit mapping between _CRS GpioIo() resources and
their names used in the driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
---
drivers/nfc/nxp-nci/i2c.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c
index 713c267acf88..7344405feddf 100644
--- a/drivers/nfc/nxp-nci/i2c.c
+++ b/drivers/nfc/nxp-nci/i2c.c
@@ -247,6 +247,15 @@ static irqreturn_t nxp_nci_i2c_irq_thread_fn(int irq, void *phy_id)
return IRQ_NONE;
}
+static const struct acpi_gpio_params firmware_gpios = { 1, 0, false };
+static const struct acpi_gpio_params enable_gpios = { 2, 0, false };
+
+static const struct acpi_gpio_mapping acpi_nxp_nci_gpios[] = {
+ { "enable-gpios", &enable_gpios, 1 },
+ { "firmware-gpios", &firmware_gpios, 1 },
+ { }
+};
+
static int nxp_nci_i2c_parse_devtree(struct i2c_client *client)
{
struct nxp_nci_i2c_phy *phy = i2c_get_clientdata(client);
@@ -269,9 +278,14 @@ static int nxp_nci_i2c_parse_devtree(struct i2c_client *client)
static int nxp_nci_i2c_acpi_config(struct nxp_nci_i2c_phy *phy)
{
struct i2c_client *client = phy->i2c_dev;
+ int r;
- phy->gpiod_en = devm_gpiod_get_index(&client->dev, NULL, 2, GPIOD_OUT_LOW);
- phy->gpiod_fw = devm_gpiod_get_index(&client->dev, NULL, 1, GPIOD_OUT_LOW);
+ r = devm_acpi_dev_add_driver_gpios(&client->dev, acpi_nxp_nci_gpios);
+ if (r)
+ return r;
+
+ phy->gpiod_en = devm_gpiod_get(&client->dev, "enable", GPIOD_OUT_LOW);
+ phy->gpiod_fw = devm_gpiod_get(&client->dev, "firmware", GPIOD_OUT_LOW);
if (IS_ERR(phy->gpiod_en) || IS_ERR(phy->gpiod_fw)) {
nfc_err(&client->dev, "No GPIOs\n");
--
2.20.1
next prev parent reply other threads:[~2019-07-25 19:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 19:34 [PATCH v3 01/14] NFC: fix attrs checks in netlink interface Andy Shevchenko
2019-07-25 19:34 ` [PATCH v3 02/14] NFC: nxp-nci: Add NXP1001 to the ACPI ID table Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 03/14] NFC: nxp-nci: Get rid of platform data Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 04/14] NFC: nxp-nci: Convert to use GPIO descriptor Andy Shevchenko
2019-07-25 19:35 ` Andy Shevchenko [this message]
2019-07-25 19:35 ` [PATCH v3 06/14] NFC: nxp-nci: Get rid of code duplication in ->probe() Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 07/14] NFC: nxp-nci: Get rid of useless label Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 08/14] NFC: nxp-nci: Constify acpi_device_id Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 09/14] NFC: nxp-nci: Drop of_match_ptr() use Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 10/14] NFC: nxp-nci: Drop comma in terminator lines Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 11/14] NFC: nxp-nci: Remove unused macro pr_fmt() Andy Shevchenko
2019-07-26 21:23 ` David Miller
2019-07-29 9:40 ` Andy Shevchenko
2019-07-29 14:58 ` Sedat Dilek
2019-07-29 15:08 ` Sedat Dilek
2019-07-25 19:35 ` [PATCH v3 12/14] NFC: nxp-nci: Remove 'default n' for the core Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 13/14] NFC: nxp-nci: Clarify on supported chips Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 14/14] NFC: nxp-nci: Fix recommendation for NFC_NXP_NCI_I2C Kconfig Andy Shevchenko
2019-07-26 8:54 ` [PATCH v3 01/14] NFC: fix attrs checks in netlink interface Sedat Dilek
2019-07-26 11:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725193511.64274-5-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=charles.gorand@effinnov.com \
--cc=clement.perrochaud@effinnov.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sedat.dilek@credativ.de \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).