From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61DEFC76194 for ; Thu, 25 Jul 2019 22:52:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37EC822C7D for ; Thu, 25 Jul 2019 22:52:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qxRoM/is" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727025AbfGYWwe (ORCPT ); Thu, 25 Jul 2019 18:52:34 -0400 Received: from mail-pl1-f202.google.com ([209.85.214.202]:55294 "EHLO mail-pl1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726997AbfGYWwe (ORCPT ); Thu, 25 Jul 2019 18:52:34 -0400 Received: by mail-pl1-f202.google.com with SMTP id u10so27146404plq.21 for ; Thu, 25 Jul 2019 15:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=RGRTCXArW2hVY3/09YdwcpCHYV4EEC+TbEhEFhWGqDY=; b=qxRoM/isL5rvTIVAwYUsmGwkKqHnfDLgxNla/G8WoF5D6/qrwGouaDMpYiVOyg6tia PXtAKesVgGN/UfD2DnHLyymPwakHzhZ8wO0o8MevAlOB2oF+WtrCEZxLVzyHtjlfHuZ6 Ih3KtdgGRjQoYPZmm6FI1AmoiGAZCrrmWbIyvxKzHL/gj0flJmbNwag6moe/uhyeFPUj e9H899uHPinNhJ/xeQtlCOAFW9z7F4YlzpIoPie9+16BPA7JQXpXTVi8BW5TNE3tY5fs XvDbdayVw+O4Q9qZpfh9uKn+TOF8smZ/S9uxYTPPt/gaUqAzwlAiPrMBQB2N3He2UWcD NZLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=RGRTCXArW2hVY3/09YdwcpCHYV4EEC+TbEhEFhWGqDY=; b=CoawbdlTHbLHfhI9wgvwSpwp/0F/tQ7wQfswdyyARoJQIN3g5eQR9VeZGVmkb4ptJo QVIJUmzunlLxbAklD2g0WZRzN6gmQ5VLipwNsW3Lv8unP0Rgg+KhdE22cR72PWA6B0fI I2qYSxMmlDhAHvycejGXwzC4pxEL3/LgBDHScR1eEz+MxSF2yHnF8Vq0/x6hsc/eaXcI DOEGBnGfa2eC7pqGmKTJ6IeTY3esgxPOO8XCOExWn+wfyZsI4f5E5Jpd9tsU3jzG6c2k Fid3lA3TUTPMz7vF3w9NOPMI/aKw+ro8dbJ/Yl3tqykB6EQ6RnAfeg478Z9inoZaTmeR dUiQ== X-Gm-Message-State: APjAAAXJQ7srcbFJjm89X5tFb0h9n1G2kGciBMJiyheKYpLaSfye0kiS r3t7kO40i9WCaIIsT0CAiNZUHVaiUY9yqYm62OueeaeSjnuZMaWly+VPh4eT3KDEQsHDYWbJdrt 7BCd04kyGp+TE1R3TqUg7JORyyMUOP5KyTJbgHRuS+cRjwBb2Uj4CTQ== X-Google-Smtp-Source: APXvYqxQwwQxO3ISgdXKDCJNAmpuriAtcV6U+EL1KG3zk0i/fuY/tv3d8GPh97CMB/f7OMKc+kWsmK4= X-Received: by 2002:a63:2b8e:: with SMTP id r136mr54790874pgr.216.1564095153316; Thu, 25 Jul 2019 15:52:33 -0700 (PDT) Date: Thu, 25 Jul 2019 15:52:24 -0700 Message-Id: <20190725225231.195090-1-sdf@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.22.0.709.g102302147b-goog Subject: [PATCH bpf-next v3 0/7] bpf/flow_dissector: support input flags From: Stanislav Fomichev To: netdev@vger.kernel.org, bpf@vger.kernel.org Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, Stanislav Fomichev , Song Liu , Willem de Bruijn , Petar Penkov Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org C flow dissector supports input flags that tell it to customize parsing by either stopping early or trying to parse as deep as possible. BPF flow dissector always parses as deep as possible which is sub-optimal. Pass input flags to the BPF flow dissector as well so it can make the same decisions. Series outline: * remove unused FLOW_DISSECTOR_F_STOP_AT_L3 flag * export FLOW_DISSECTOR_F_XXX flags as uapi and pass them to BPF flow dissector * add documentation for the export flags * support input flags in BPF_PROG_TEST_RUN via ctx_{in,out} * sync uapi to tools * support FLOW_DISSECTOR_F_PARSE_1ST_FRAG in selftest * support FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL in kernel and selftest * support FLOW_DISSECTOR_F_STOP_AT_ENCAP in selftest Pros: * makes BPF flow dissector faster by avoiding burning extra cycles * existing BPF progs continue to work by ignoring the flags and always parsing as deep as possible Cons: * new UAPI which we need to support (OTOH, if we need to deprecate some flags, we can just stop setting them upon calling BPF programs) Some numbers (with .repeat = 4000000 in test_flow_dissector): test_flow_dissector:PASS:ipv4-frag 35 nsec test_flow_dissector:PASS:ipv4-frag 35 nsec test_flow_dissector:PASS:ipv4-no-frag 32 nsec test_flow_dissector:PASS:ipv4-no-frag 32 nsec test_flow_dissector:PASS:ipv6-frag 39 nsec test_flow_dissector:PASS:ipv6-frag 39 nsec test_flow_dissector:PASS:ipv6-no-frag 36 nsec test_flow_dissector:PASS:ipv6-no-frag 36 nsec test_flow_dissector:PASS:ipv6-flow-label 36 nsec test_flow_dissector:PASS:ipv6-flow-label 36 nsec test_flow_dissector:PASS:ipv6-no-flow-label 33 nsec test_flow_dissector:PASS:ipv6-no-flow-label 33 nsec test_flow_dissector:PASS:ipip-encap 38 nsec test_flow_dissector:PASS:ipip-encap 38 nsec test_flow_dissector:PASS:ipip-no-encap 32 nsec test_flow_dissector:PASS:ipip-no-encap 32 nsec The improvement is around 10%, but it's in a tight cache-hot BPF_PROG_TEST_RUN loop. Cc: Song Liu Cc: Willem de Bruijn Cc: Petar Penkov Stanislav Fomichev (7): bpf/flow_dissector: pass input flags to BPF flow dissector program bpf/flow_dissector: document flags bpf/flow_dissector: support flags in BPF_PROG_TEST_RUN tools/bpf: sync bpf_flow_keys flags selftests/bpf: support BPF_FLOW_DISSECTOR_F_PARSE_1ST_FRAG bpf/flow_dissector: support ipv6 flow_label and BPF_FLOW_DISSECTOR_F_STOP_AT_FLOW_LABEL selftests/bpf: support BPF_FLOW_DISSECTOR_F_STOP_AT_ENCAP Documentation/bpf/prog_flow_dissector.rst | 18 ++ include/linux/skbuff.h | 2 +- include/uapi/linux/bpf.h | 6 + net/bpf/test_run.c | 39 ++- net/core/flow_dissector.c | 21 +- tools/include/uapi/linux/bpf.h | 6 + .../selftests/bpf/prog_tests/flow_dissector.c | 243 +++++++++++++++++- tools/testing/selftests/bpf/progs/bpf_flow.c | 47 +++- 8 files changed, 368 insertions(+), 14 deletions(-) -- 2.22.0.709.g102302147b-goog