From: Stephen Hemminger <stephen@networkplumber.org>
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] iproute2: devlink: use sys/queue.h from libbsd as a fallback
Date: Fri, 26 Jul 2019 11:29:56 -0700 [thread overview]
Message-ID: <20190726112956.3b54f906@hermes.lan> (raw)
In-Reply-To: <20190724081838.18198-1-slyfox@gentoo.org>
On Wed, 24 Jul 2019 09:18:38 +0100
Sergei Trofimovich <slyfox@gentoo.org> wrote:
> On sys/queue.h does not exist linux-musl targets and
> fails build as:
>
> devlink.c:28:10: fatal error: sys/queue.h: No such file or directory
> 28 | #include <sys/queue.h>
> | ^~~~~~~~~~~~~
>
> The change pulls in 'sys/queue.h' from libbsd in case
> system headers don't already provides it.
>
> Tested on linux-musl and linux-glibc.
>
> Bug: https://bugs.gentoo.org/690486
> CC: Stephen Hemminger <stephen@networkplumber.org>
> CC: netdev@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
This is ugly and causes more maintainability issues.
Maybe just fix devlink not to depend on sys/queue.h at all.
It makes more sense to have common code style and usage across all of
iproute2.
We already have local version list.h, why continue with BSD stuff.
next prev parent reply other threads:[~2019-07-26 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 8:18 [PATCH] iproute2: devlink: use sys/queue.h from libbsd as a fallback Sergei Trofimovich
2019-07-26 18:29 ` Stephen Hemminger [this message]
2019-07-26 21:01 ` [PATCH v2] iproute2: devlink: port from sys/queue.h to list.h Sergei Trofimovich
2019-07-26 22:02 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726112956.3b54f906@hermes.lan \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).