From: Andrew Lunn <andrew@lunn.ch>
To: xiaofeis@codeaurora.org
Cc: vkoul@kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] net: dsa: qca8k: enable port flow control
Date: Fri, 26 Jul 2019 15:29:19 +0200 [thread overview]
Message-ID: <20190726132919.GB18223@lunn.ch> (raw)
In-Reply-To: <e2c51913e0e38450b09ef8f06bf259c0@codeaurora.org>
> I didn't compile it on this tree, same code is just compiled and tested on
> kernel v4.14.
For kernel development work, v4.14 is dead. It died 12th November
2017. It gets backports of bug fixes, but kernel developers otherwise
don't touch it.
> We are working on one google project, all the change is
> required to upstream by Google.
> But if I do the change based on the new type for kernel 5.3, then the commit
> can't be used directly for Google's project.
So you will need to backport the change. In this case, you will have a
very different patch in v4.14 than in mainline, due to changes like
this. That is part of the pain in using such an old kernel.
You should use the function
void phy_support_asym_pause(struct phy_device *phydev);
to indicate the MAC supports asym pause.
Andrew
next prev parent reply other threads:[~2019-07-26 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 5:02 [PATCH v2] net: dsa: qca8k: enable port flow control xiaofeis
2019-07-24 17:05 ` kbuild test robot
2019-07-24 17:50 ` Andrew Lunn
[not found] ` <351b5292d597e47d69d0dcfd5af6a188@codeaurora.org>
[not found] ` <20190725130135.GA21952@lunn.ch>
[not found] ` <e2c51913e0e38450b09ef8f06bf259c0@codeaurora.org>
2019-07-26 13:29 ` Andrew Lunn [this message]
2019-07-27 1:15 ` xiaofeis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726132919.GB18223@lunn.ch \
--to=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=xiaofeis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).