* [PATCH] iplink_can: fix format output of clock with flag -details
@ 2019-07-26 13:06 Antonio Borneo
2019-07-26 22:04 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Antonio Borneo @ 2019-07-26 13:06 UTC (permalink / raw)
To: netdev
The command
ip -details link show can0
prints in the last line the value of the clock frequency attached
to the name of the following value "numtxqueues", e.g.
clock 49500000numtxqueues 1 numrxqueues 1 gso_max_size
65536 gso_max_segs 65535
Add the missing space after the clock value.
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
---
ip/iplink_can.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/iplink_can.c b/ip/iplink_can.c
index 5bf490a9..735ab941 100644
--- a/ip/iplink_can.c
+++ b/ip/iplink_can.c
@@ -545,7 +545,7 @@ static void can_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
print_int(PRINT_ANY,
"clock",
- "\n clock %d",
+ "\n clock %d ",
clock->freq);
}
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iplink_can: fix format output of clock with flag -details
2019-07-26 13:06 [PATCH] iplink_can: fix format output of clock with flag -details Antonio Borneo
@ 2019-07-26 22:04 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2019-07-26 22:04 UTC (permalink / raw)
To: Antonio Borneo; +Cc: netdev
On Fri, 26 Jul 2019 15:06:09 +0200
Antonio Borneo <borneo.antonio@gmail.com> wrote:
> The command
> ip -details link show can0
> prints in the last line the value of the clock frequency attached
> to the name of the following value "numtxqueues", e.g.
> clock 49500000numtxqueues 1 numrxqueues 1 gso_max_size
> 65536 gso_max_segs 65535
>
> Add the missing space after the clock value.
>
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Applied, but CAN looks like it doesn't support single line output correctly.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-26 22:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-26 13:06 [PATCH] iplink_can: fix format output of clock with flag -details Antonio Borneo
2019-07-26 22:04 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).