From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51940C433FF for ; Sat, 27 Jul 2019 20:52:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 275332075C for ; Sat, 27 Jul 2019 20:52:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388350AbfG0Uws (ORCPT ); Sat, 27 Jul 2019 16:52:48 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40110 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387841AbfG0Uws (ORCPT ); Sat, 27 Jul 2019 16:52:48 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B24B41534D12A; Sat, 27 Jul 2019 13:52:47 -0700 (PDT) Date: Sat, 27 Jul 2019 13:52:45 -0700 (PDT) Message-Id: <20190727.135245.191991967753814130.davem@davemloft.net> To: thierry.reding@gmail.com Cc: joabreu@synopsys.com, alexandre.torgue@st.com, peppe.cavallaro@st.com, jonathanh@nvidia.com, netdev@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next 2/2] net: stmmac: Do not request stmmaceth clock From: David Miller In-Reply-To: <20190726102741.27872-2-thierry.reding@gmail.com> References: <20190726102741.27872-1-thierry.reding@gmail.com> <20190726102741.27872-2-thierry.reding@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 27 Jul 2019 13:52:48 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Thierry Reding Date: Fri, 26 Jul 2019 12:27:41 +0200 > From: Thierry Reding > > The stmmaceth clock is specified by the slave_bus and apb_pclk clocks in > the device tree bindings for snps,dwc-qos-ethernet-4.10 compatible nodes > of this IP. > > The subdrivers for these bindings will be requesting the stmmac clock > correctly at a later point, so there is no need to request it here and > cause an error message to be printed to the kernel log. > > Signed-off-by: Thierry Reding Applied.