From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
aaro.koskinen@iki.fi, arnd@arndb.de
Subject: Re: [PATCH 2/2] staging/octeon: Allow test build on !MIPS
Date: Sat, 27 Jul 2019 12:57:06 +0200 [thread overview]
Message-ID: <20190727105706.GB458@kroah.com> (raw)
In-Reply-To: <20190726174425.6845-3-willy@infradead.org>
On Fri, Jul 26, 2019 at 10:44:25AM -0700, Matthew Wilcox wrote:
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>
> Add compile test support by moving all includes of files under
> asm/octeon into octeon-ethernet.h, and if we're not on MIPS,
> stub out all the calls into the octeon support code in octeon-stubs.h
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> drivers/staging/octeon/Kconfig | 2 +-
> drivers/staging/octeon/ethernet-defines.h | 2 -
> drivers/staging/octeon/ethernet-mdio.c | 6 +-
> drivers/staging/octeon/ethernet-mem.c | 5 +-
> drivers/staging/octeon/ethernet-rgmii.c | 10 +-
> drivers/staging/octeon/ethernet-rx.c | 13 +-
> drivers/staging/octeon/ethernet-rx.h | 2 -
> drivers/staging/octeon/ethernet-sgmii.c | 8 +-
> drivers/staging/octeon/ethernet-spi.c | 10 +-
> drivers/staging/octeon/ethernet-tx.c | 12 +-
> drivers/staging/octeon/ethernet-util.h | 4 -
> drivers/staging/octeon/ethernet.c | 12 +-
> drivers/staging/octeon/octeon-ethernet.h | 29 +-
> drivers/staging/octeon/octeon-stubs.h | 1429 +++++++++++++++++++++
> 14 files changed, 1466 insertions(+), 78 deletions(-)
> create mode 100644 drivers/staging/octeon/octeon-stubs.h
No real objection from me, having this driver able to be built on
non-mips systems would be great.
But wow, that stubs.h file is huge, you really need all of that?
There's no way to include the files from the mips "core" directly
instead for some of it?
If not, that's fine, and all of this can go through net-next:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2019-07-27 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 17:44 [PATCH 0/2] Fix Octeon to build on !MIPS Matthew Wilcox
2019-07-26 17:44 ` [PATCH 1/2] octeon: Fix typo Matthew Wilcox
2019-07-29 17:44 ` David Miller
2019-07-26 17:44 ` [PATCH 2/2] staging/octeon: Allow test build on !MIPS Matthew Wilcox
2019-07-27 10:57 ` Greg KH [this message]
2019-07-27 14:28 ` Matthew Wilcox
2019-07-27 14:51 ` Greg KH
2019-07-29 17:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190727105706.GB458@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aaro.koskinen@iki.fi \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).