From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
aaro.koskinen@iki.fi, arnd@arndb.de
Subject: Re: [PATCH 2/2] staging/octeon: Allow test build on !MIPS
Date: Sat, 27 Jul 2019 16:51:45 +0200 [thread overview]
Message-ID: <20190727145145.GA21910@kroah.com> (raw)
In-Reply-To: <20190727142826.GA12889@bombadil.infradead.org>
On Sat, Jul 27, 2019 at 07:28:26AM -0700, Matthew Wilcox wrote:
> On Sat, Jul 27, 2019 at 12:57:06PM +0200, Greg KH wrote:
> > No real objection from me, having this driver able to be built on
> > non-mips systems would be great.
> >
> > But wow, that stubs.h file is huge, you really need all of that?
> > There's no way to include the files from the mips "core" directly
> > instead for some of it?
>
> I don't know. I went the route of copying each structure/enum wholesale
> as I came across it in the build log rather than taking only the pieces
> of it that I needed. My time versus a few hundred lines of source?
>
> I think that a more wholesale restructuring of this driver would be
> helpful; there are a number of structures that are only used in the
> driver and not in the arch code, and those could then be removed from
> the stubs file. But I have no long term investment in this driver;
> it just annoyed me to not be able to build it.
Ok, again, no objection from me, thanks for doing this work.
greg k-h
next prev parent reply other threads:[~2019-07-27 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 17:44 [PATCH 0/2] Fix Octeon to build on !MIPS Matthew Wilcox
2019-07-26 17:44 ` [PATCH 1/2] octeon: Fix typo Matthew Wilcox
2019-07-29 17:44 ` David Miller
2019-07-26 17:44 ` [PATCH 2/2] staging/octeon: Allow test build on !MIPS Matthew Wilcox
2019-07-27 10:57 ` Greg KH
2019-07-27 14:28 ` Matthew Wilcox
2019-07-27 14:51 ` Greg KH [this message]
2019-07-29 17:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190727145145.GA21910@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aaro.koskinen@iki.fi \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).