Re: [PATCH] rocker: fix memory leaks of fib_work on two error return paths

David Ahern
2019-07-28T00:32:43Z

On 7/27/19 5:37 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently there are two error return paths that leak memory allocated
> to fib_work. Fix this by kfree'ing fib_work before returning.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: 19a9d136f198 ("ipv4: Flag fib_info with a fib_nh using IPv6 gateway")
> Fixes: dbcc4fa718ee ("rocker: Fail attempts to use routes with nexthop objects")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/ethernet/rocker/rocker_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>

Thanks for the patch,
Reviewed-by: David Ahern <dsahern@gmail.com>