From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: wenxu@ucloud.cn
Cc: pablo@netfilter.org, fw@strlen.de,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 2/3] flow_offload: Support get default block from tc immediately
Date: Sun, 28 Jul 2019 13:16:53 -0700 [thread overview]
Message-ID: <20190728131653.6af72a87@cakuba.netronome.com> (raw)
In-Reply-To: <1564296769-32294-3-git-send-email-wenxu@ucloud.cn>
On Sun, 28 Jul 2019 14:52:48 +0800, wenxu@ucloud.cn wrote:
> From: wenxu <wenxu@ucloud.cn>
>
> When thre indr device register, it can get the default block
> from tc immediately if the block is exist.
>
> Signed-off-by: wenxu <wenxu@ucloud.cn>
> ---
> v3: no change
> v4: get tc default block without callback
Please stop reposting new versions of the patches while discussion is
ongoing, it makes it harder to follow.
The TC default block is there because the indirect registration may
happen _after_ the block is installed and populated. It's the device
driver that usually does the indirect registration, the tunnel device
and its rules may already be set when device driver is loaded or
reloaded.
I don't know the nft code, but it seems unlikely it wouldn't have the
same problem/need..
Please explain.
next prev parent reply other threads:[~2019-07-28 20:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 6:52 [PATCH net-next v4 0/3] flow_offload: add indr-block in nf_table_offload wenxu
2019-07-28 6:52 ` [PATCH net-next v4 1/3] flow_offload: move tc indirect block to flow offload wenxu
2019-07-29 11:13 ` Jiri Pirko
2019-07-29 12:47 ` wenxu
2019-07-29 13:13 ` Jiri Pirko
2019-07-29 11:15 ` Jiri Pirko
2019-07-28 6:52 ` [PATCH net-next v4 2/3] flow_offload: Support get default block from tc immediately wenxu
2019-07-28 20:16 ` Jakub Kicinski [this message]
2019-07-29 2:43 ` wenxu
2019-07-29 4:42 ` Jakub Kicinski
2019-07-29 7:05 ` wenxu
2019-07-29 16:51 ` Jakub Kicinski
2019-07-29 7:18 ` wenxu
2019-07-29 16:55 ` Jakub Kicinski
2019-07-30 0:10 ` wenxu
2019-07-28 6:52 ` [PATCH net-next v4 3/3] netfilter: nf_tables_offload: support indr block call wenxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728131653.6af72a87@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).