From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2621C433FF for ; Mon, 29 Jul 2019 16:46:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2A7D206E0 for ; Mon, 29 Jul 2019 16:46:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728459AbfG2QqP (ORCPT ); Mon, 29 Jul 2019 12:46:15 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35760 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728170AbfG2QqP (ORCPT ); Mon, 29 Jul 2019 12:46:15 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8B1B112665353; Mon, 29 Jul 2019 09:46:14 -0700 (PDT) Date: Mon, 29 Jul 2019 09:46:13 -0700 (PDT) Message-Id: <20190729.094613.2239689143737241909.davem@davemloft.net> To: juliana.rodrigueiro@intra2net.com Cc: isdn@linux-pingi.de, netdev@vger.kernel.org Subject: Re: [PATCH] isdn: hfcsusb: Fix mISDN driver crash caused by transfer buffer on the stack From: David Miller In-Reply-To: <2635856.so0i2TFZOM@rocinante.m.i2n> References: <2635856.so0i2TFZOM@rocinante.m.i2n> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 29 Jul 2019 09:46:14 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Juliana Rodrigueiro Date: Mon, 29 Jul 2019 10:20:56 +0200 > @@ -1705,12 +1705,22 @@ static int > setup_hfcsusb(struct hfcsusb *hw) > { > u_char b; > + int ret; > + void *dmabuf = kmalloc(sizeof(u_char), GFP_KERNEL); Please order these local variable declarations from longest to shortest line. Thank you.