From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11248C433FF for ; Mon, 29 Jul 2019 18:03:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3EC82171F for ; Mon, 29 Jul 2019 18:03:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729119AbfG2SDn (ORCPT ); Mon, 29 Jul 2019 14:03:43 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36994 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729109AbfG2SDn (ORCPT ); Mon, 29 Jul 2019 14:03:43 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 15985140505C4; Mon, 29 Jul 2019 11:03:43 -0700 (PDT) Date: Mon, 29 Jul 2019 11:03:42 -0700 (PDT) Message-Id: <20190729.110342.703558396264560468.davem@davemloft.net> To: skalluru@marvell.com Cc: netdev@vger.kernel.org, mkalderon@marvell.com, aelior@marvell.com Subject: Re: [PATCH net-next v3 2/2] qed: Add driver API for flashing the config attributes. From: David Miller In-Reply-To: <20190728015549.27051-3-skalluru@marvell.com> References: <20190728015549.27051-1-skalluru@marvell.com> <20190728015549.27051-3-skalluru@marvell.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 29 Jul 2019 11:03:43 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sudarsana Reddy Kalluru Date: Sat, 27 Jul 2019 18:55:49 -0700 > @@ -2268,6 +2330,9 @@ static int qed_nvm_flash(struct qed_dev *cdev, const char *name) > rc = qed_nvm_flash_image_access(cdev, &data, > &check_resp); > break; > + case QED_NVM_FLASH_CMD_NVM_CFG_ID: > + rc = qed_nvm_flash_cfg_write(cdev, &data); > + break; > default: > DP_ERR(cdev, "Unknown command %08x\n", cmd_type); I don't see how any existing portable interface can cause this new code to actually be used. You have to explain this to me.