[PATCH iproute2 0/1] Fix s64 argument parsing

[PATCH iproute2 0/1] Fix s64 argument parsing

[Kurt Kanzenbach]

Hi,

while using the TAPRIO Qdisc on ARM32 I've noticed that the base_time parameter is
incorrectly configured. The problem is the utility function get_s64() used by
TAPRIO doesn't parse the value correctly.

Thanks,
Kurt

Kurt Kanzenbach (1):
  utils: Fix get_s64() function

 lib/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.11.0

[PATCH iproute2 1/1] utils: Fix get_s64() function

[Kurt Kanzenbach]

get_s64() uses internally strtoll() to parse the value out of a given
string. strtoll() returns a long long. However, the intermediate variable is
long only which might be 32 bit on some systems. So, fix it.

Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
 lib/utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/utils.c b/lib/utils.c
index be0f11b00280..9c3702fd4a04 100644
--- a/lib/utils.c
+++ b/lib/utils.c
@@ -390,7 +390,7 @@ int get_u8(__u8 *val, const char *arg, int base)
 
 int get_s64(__s64 *val, const char *arg, int base)
 {
-	long res;
+	long long res;
 	char *ptr;
 
 	errno = 0;
-- 
2.11.0

Re: [PATCH iproute2 0/1] Fix s64 argument parsing

[Kurt Kanzenbach]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

On Thu, Jul 04, 2019 at 02:24:26PM +0200, Kurt Kanzenbach wrote:
> Hi,
>
> while using the TAPRIO Qdisc on ARM32 I've noticed that the base_time parameter is
> incorrectly configured. The problem is the utility function get_s64() used by
> TAPRIO doesn't parse the value correctly.

polite ping.

>
> Thanks,
> Kurt
>
> Kurt Kanzenbach (1):
>   utils: Fix get_s64() function
>
>  lib/utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.11.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH iproute2 0/1] Fix s64 argument parsing

[Stephen Hemminger]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

On Mon, 29 Jul 2019 13:04:09 +0200
Kurt Kanzenbach <kurt.kanzenbach@linutronix.de> wrote:

> On Thu, Jul 04, 2019 at 02:24:26PM +0200, Kurt Kanzenbach wrote:
> > Hi,
> >
> > while using the TAPRIO Qdisc on ARM32 I've noticed that the base_time parameter is
> > incorrectly configured. The problem is the utility function get_s64() used by
> > TAPRIO doesn't parse the value correctly.  
> 
> polite ping.
> 
> >
> > Thanks,
> > Kurt
> >
> > Kurt Kanzenbach (1):
> >   utils: Fix get_s64() function
> >
> >  lib/utils.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --
> > 2.11.0
> >  

Not sure why this got marked "Changes Requested"
Applied.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]