From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: clement.perrochaud@effinnov.com, charles.gorand@effinnov.com,
netdev@vger.kernel.org, sedat.dilek@credativ.de,
sedat.dilek@gmail.com
Subject: Re: [PATCH v3 11/14] NFC: nxp-nci: Remove unused macro pr_fmt()
Date: Mon, 29 Jul 2019 12:40:47 +0300 [thread overview]
Message-ID: <20190729094047.GH9224@smile.fi.intel.com> (raw)
In-Reply-To: <20190726.142346.407773857500139523.davem@davemloft.net>
On Fri, Jul 26, 2019 at 02:23:46PM -0700, David Miller wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date: Thu, 25 Jul 2019 22:35:08 +0300
>
> > The macro had never been used.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Tested-by: Sedat Dilek <sedat.dilek@gmail.com>
> ...
> > @@ -12,8 +12,6 @@
> > * Copyright (C) 2012 Intel Corporation. All rights reserved.
> > */
> >
> > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>
> If there are any kernel log messages generated, which is the case in
> this file, this is used.
AFAICS no, it's not.
All nfc_*() macros are built on top of dev_*() ones for which pr_fmt() is no-op.
If we would like to have it in that way, we rather should use dev_fmt().
> Also, please resubmit this series with a proper header posting containing
> a high level description of what this patch series does, how it is doing it,
> and why it is doing it that way. Also include a changelog.
Will do.
Thank you for review!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-07-29 9:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 19:34 [PATCH v3 01/14] NFC: fix attrs checks in netlink interface Andy Shevchenko
2019-07-25 19:34 ` [PATCH v3 02/14] NFC: nxp-nci: Add NXP1001 to the ACPI ID table Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 03/14] NFC: nxp-nci: Get rid of platform data Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 04/14] NFC: nxp-nci: Convert to use GPIO descriptor Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 05/14] NFC: nxp-nci: Add GPIO ACPI mapping table Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 06/14] NFC: nxp-nci: Get rid of code duplication in ->probe() Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 07/14] NFC: nxp-nci: Get rid of useless label Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 08/14] NFC: nxp-nci: Constify acpi_device_id Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 09/14] NFC: nxp-nci: Drop of_match_ptr() use Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 10/14] NFC: nxp-nci: Drop comma in terminator lines Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 11/14] NFC: nxp-nci: Remove unused macro pr_fmt() Andy Shevchenko
2019-07-26 21:23 ` David Miller
2019-07-29 9:40 ` Andy Shevchenko [this message]
2019-07-29 14:58 ` Sedat Dilek
2019-07-29 15:08 ` Sedat Dilek
2019-07-25 19:35 ` [PATCH v3 12/14] NFC: nxp-nci: Remove 'default n' for the core Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 13/14] NFC: nxp-nci: Clarify on supported chips Andy Shevchenko
2019-07-25 19:35 ` [PATCH v3 14/14] NFC: nxp-nci: Fix recommendation for NFC_NXP_NCI_I2C Kconfig Andy Shevchenko
2019-07-26 8:54 ` [PATCH v3 01/14] NFC: fix attrs checks in netlink interface Sedat Dilek
2019-07-26 11:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729094047.GH9224@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=charles.gorand@effinnov.com \
--cc=clement.perrochaud@effinnov.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sedat.dilek@credativ.de \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).