From: Jiri Benc <jbenc@redhat.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: davem@davemloft.net, sbrivio@redhat.com, sd@queasysnail.net,
liuhangbin@gmail.com, dsahern@gmail.com,
natechancellor@gmail.com, tglx@linutronix.de,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: geneve: Fix a possible null-pointer dereference in geneve_link_config()
Date: Mon, 29 Jul 2019 12:52:21 +0200 [thread overview]
Message-ID: <20190729125221.00baf700@redhat.com> (raw)
In-Reply-To: <20190729123055.5a7ba416@redhat.com>
On Mon, 29 Jul 2019 12:30:55 +0200, Jiri Benc wrote:
> Are you sure rt6_lookup can never return a non-NULL rt with rt->dst.dev
> being NULL? You'd leak the reference in such case.
In fact, you're introducing a bug, not fixing one. ip6_rt_put does
accept NULL parameter. And it seems you already have been told that?
Nacked-by: Jiri Benc <jbenc@redhat.com>
Jiri
prev parent reply other threads:[~2019-07-29 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 10:26 [PATCH] net: geneve: Fix a possible null-pointer dereference in geneve_link_config() Jia-Ju Bai
2019-07-29 10:30 ` Jiri Benc
2019-07-29 10:52 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729125221.00baf700@redhat.com \
--to=jbenc@redhat.com \
--cc=baijiaju1990@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=sd@queasysnail.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).