From: Andrew Lunn <andrew@lunn.ch>
To: xiaofeis@codeaurora.org
Cc: davem@davemloft.net, vkoul@kernel.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org,
vivien.didelot@gmail.com, f.fainelli@gmail.com,
niklas.cassel@linaro.org, xiazha@codeaurora.org
Subject: Re: [PATCH v3] net: dsa: qca8k: enable port flow control
Date: Mon, 29 Jul 2019 15:23:42 +0200 [thread overview]
Message-ID: <20190729132342.GA4110@lunn.ch> (raw)
In-Reply-To: <fa444b03b42a2cb72037bc73a62f1976@codeaurora.org>
> But our qca8k HW can auto sync the pause status to MAC from phy with the
> auto-negotiated result.
> So no need to set in qca8k_adjust_link, since there is one setting in
> qca8k_port_set_status: mask |= QCA8K_PORT_STATUS_LINK_AUTO;
How does the auto-sync actually work? Does the MAC make MDIO reads to
the PHY? That is generally unsafe, since some PHYs support pages, and
the PHY driver might be using a different page while the MAC tries to
access the auto-neg results.
Do any of the ports support an external PHY? The auto-sync might not
work in that condition as well. Different register layout, c45 not
c22, etc.
The safest option is to explicitly set the MAC flow configuration
based on the values in phydev.
Andrew
next prev parent reply other threads:[~2019-07-29 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 0:57 [PATCH v3] net: dsa: qca8k: enable port flow control xiaofeis
2019-07-28 22:31 ` Andrew Lunn
2019-07-29 5:01 ` xiaofeis
2019-07-29 13:23 ` Andrew Lunn [this message]
2019-07-30 3:01 ` xiaofeis
2019-07-30 22:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729132342.GA4110@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=vivien.didelot@gmail.com \
--cc=vkoul@kernel.org \
--cc=xiaofeis@codeaurora.org \
--cc=xiazha@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).