From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: "Jonathan Lemon" <jonathan.lemon@gmail.com>
Cc: davem@davemloft.net, kernel-team@fb.com, netdev@vger.kernel.org,
"Matthew Wilcox" <willy@infradead.org>
Subject: Re: [PATCH 1/3 net-next] linux: Add skb_frag_t page_offset accessors
Date: Mon, 29 Jul 2019 14:25:58 -0700 [thread overview]
Message-ID: <20190729142548.028d5a2b@cakuba.netronome.com> (raw)
In-Reply-To: <20190729142211.43b5ccd8@cakuba.netronome.com>
On Mon, 29 Jul 2019 14:22:11 -0700, Jakub Kicinski wrote:
> > > I realize you're following the existing code, but should we perhaps
> > > use
> > > the latest kdoc syntax? '()' after function name, and args should have
> > > '@' prefix, '%' would be for constants.
> >
> > That would be a task for a different cleanup. Not that I disagree with
> > you, but there's also nothing worse than mixing styles in the same file.
>
> Funny you should say that given that (a) I'm commenting on the new code
> you're adding, and (b) you did do an unrelated spelling fix above ;)
Ah, sorry I misread your comment there.
Some code already uses '()' in this file, as for the '%' skb_frag_
functions are the only one which have this mistake, the rest of kdoc
is correct.
next prev parent reply other threads:[~2019-07-29 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 17:19 [PATCH 0/3 net-next] Finish conversion of skb_frag_t to bio_vec Jonathan Lemon
2019-07-29 17:19 ` [PATCH 1/3 net-next] linux: Add skb_frag_t page_offset accessors Jonathan Lemon
2019-07-29 20:50 ` Jakub Kicinski
2019-07-29 21:02 ` Jonathan Lemon
2019-07-29 21:22 ` Jakub Kicinski
2019-07-29 21:25 ` David Miller
2019-07-29 21:25 ` Jakub Kicinski [this message]
2019-07-29 21:53 ` Jonathan Lemon
2019-07-29 22:02 ` Jakub Kicinski
2019-07-29 21:37 ` Jonathan Lemon
2019-07-29 17:19 ` [PATCH 2/3 net-next] net: Use skb_frag_off accessors Jonathan Lemon
2019-07-29 17:19 ` [PATCH 3/3 net-next] linux: Remove bvec page_offset, use bv_offset Jonathan Lemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729142548.028d5a2b@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=jonathan.lemon@gmail.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).