From: David Miller <davem@davemloft.net>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH net] net: bridge: mcast: don't delete permanent entries when fast leave is enabled
Date: Tue, 30 Jul 2019 10:18:11 -0700 (PDT) [thread overview]
Message-ID: <20190730.101811.1836331521043535108.davem@davemloft.net> (raw)
In-Reply-To: <20190730112100.18156-1-nikolay@cumulusnetworks.com>
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Tue, 30 Jul 2019 14:21:00 +0300
> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index 3d8deac2353d..f8cac3702712 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1388,6 +1388,9 @@ br_multicast_leave_group(struct net_bridge *br,
> if (!br_port_group_equal(p, port, src))
> continue;
>
> + if (p->flags & MDB_PG_FLAGS_PERMANENT)
> + break;
> +
Like David, I also don't understand why this can be a break. Is it because
permanent entries are always the last on the list? Why will there be no
other entries that might need to be processed on the list?
next prev parent reply other threads:[~2019-07-30 17:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 11:21 [PATCH net] net: bridge: mcast: don't delete permanent entries when fast leave is enabled Nikolay Aleksandrov
2019-07-30 13:58 ` David Ahern
2019-07-30 14:00 ` Nikolay Aleksandrov
2019-07-30 17:18 ` David Miller [this message]
2019-07-30 17:21 ` Nikolay Aleksandrov
2019-07-30 17:23 ` Nikolay Aleksandrov
2019-07-31 23:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730.101811.1836331521043535108.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).