From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE7F0C32750 for ; Tue, 30 Jul 2019 21:22:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A19FB20665 for ; Tue, 30 Jul 2019 21:22:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387659AbfG3VWj (ORCPT ); Tue, 30 Jul 2019 17:22:39 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55482 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727737AbfG3VWj (ORCPT ); Tue, 30 Jul 2019 17:22:39 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 01A4E14A8CC6D; Tue, 30 Jul 2019 14:22:38 -0700 (PDT) Date: Tue, 30 Jul 2019 14:22:38 -0700 (PDT) Message-Id: <20190730.142238.1475873068715429404.davem@davemloft.net> To: axboe@fb.com Cc: jonathan.lemon@gmail.com, willy@infradead.org, jakub.kicinski@netronome.com, Kernel-team@fb.com, netdev@vger.kernel.org Subject: Re: [PATCH v2 0/3 net-next] Finish conversion of skb_frag_t to bio_vec From: David Miller In-Reply-To: <1d34658b-a807-44ae-756a-d55dead27f94@fb.com> References: <20190730144034.444022-1-jonathan.lemon@gmail.com> <1d34658b-a807-44ae-756a-d55dead27f94@fb.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 Jul 2019 14:22:39 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jens Axboe Date: Tue, 30 Jul 2019 20:49:09 +0000 > Pretty appalled to see this abomination: > > net: Convert skb_frag_t to bio_vec > > There are a lot of users of frag->page_offset, so use a union > to avoid converting those users today. > > Signed-off-by: Matthew Wilcox (Oracle) > Signed-off-by: David S. Miller > > show up in the net tree without even having been posted on a > block list... > > At least this kills this ugly thing. Sorry about that Jens, but at least as you say it's gone now.