From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC6C8C32750 for ; Tue, 30 Jul 2019 21:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B16B1206E0 for ; Tue, 30 Jul 2019 21:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727508AbfG3Vk1 (ORCPT ); Tue, 30 Jul 2019 17:40:27 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55706 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbfG3Vk1 (ORCPT ); Tue, 30 Jul 2019 17:40:27 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9A5DD14E340BE; Tue, 30 Jul 2019 14:40:26 -0700 (PDT) Date: Tue, 30 Jul 2019 14:40:26 -0700 (PDT) Message-Id: <20190730.144026.1606872258602139673.davem@davemloft.net> To: jon.maloy@ericsson.com Cc: netdev@vger.kernel.org, tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au, lxin@redhat.com, shuali@redhat.com, ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net Subject: Re: [net 1/1] tipc: fix unitilized skb list crash From: David Miller In-Reply-To: <1564510750-19531-1-git-send-email-jon.maloy@ericsson.com> References: <1564510750-19531-1-git-send-email-jon.maloy@ericsson.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 Jul 2019 14:40:26 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jon Maloy Date: Tue, 30 Jul 2019 20:19:10 +0200 > Our test suite somtimes provokes the following crash: > > Description of problem: ... > The reason is that the skb list tipc_socket::mc_method.deferredq only > is initialized for connectionless sockets, while nothing stops arriving > multicast messages from being filtered by connection oriented sockets, > with subsequent access to the said list. > > We fix this by initializing the list unconditionally at socket creation. > This eliminates the crash, while the message still is dropped further > down in tipc_sk_filter_rcv() as it should be. > > Reported-by: Li Shuang > Signed-off-by: Jon Maloy Applied and queued up for -stable, thank you.