From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA5D7C32750 for ; Tue, 30 Jul 2019 22:08:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C655F205C9 for ; Tue, 30 Jul 2019 22:08:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388015AbfG3WIN (ORCPT ); Tue, 30 Jul 2019 18:08:13 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56088 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726253AbfG3WIN (ORCPT ); Tue, 30 Jul 2019 18:08:13 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 97252146F6EF4; Tue, 30 Jul 2019 15:08:12 -0700 (PDT) Date: Tue, 30 Jul 2019 15:08:12 -0700 (PDT) Message-Id: <20190730.150812.942736721465627162.davem@davemloft.net> To: xiaofeis@codeaurora.org Cc: vkoul@kernel.org, netdev@vger.kernel.org, andrew@lunn.ch, linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, niklas.cassel@linaro.org, xiazha@codeaurora.org Subject: Re: [PATCH v3] net: dsa: qca8k: enable port flow control From: David Miller In-Reply-To: <1564275470-52666-1-git-send-email-xiaofeis@codeaurora.org> References: <1564275470-52666-1-git-send-email-xiaofeis@codeaurora.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 30 Jul 2019 15:08:13 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: xiaofeis Date: Sun, 28 Jul 2019 08:57:50 +0800 > Set phy device advertising to enable MAC flow control. > > Signed-off-by: Xiaofei Shen I've read the discussion over a few times and if internal PHY is the only thing supported, and the specific setup this driver supports uses internal signalling to sync the PHY and MAC settings I guess this is OK although suboptimal. So applied, thanks. Thanks.