From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 744B0C433FF for ; Tue, 30 Jul 2019 09:48:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 494E420679 for ; Tue, 30 Jul 2019 09:48:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sDifU7u9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731032AbfG3Jr3 (ORCPT ); Tue, 30 Jul 2019 05:47:29 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:36590 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730150AbfG3Jr2 (ORCPT ); Tue, 30 Jul 2019 05:47:28 -0400 Received: by mail-wr1-f67.google.com with SMTP id n4so65099295wrs.3; Tue, 30 Jul 2019 02:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bCbdxxLbqxrpV82n9Yp3CBGNk09BtzYShH1n+PyQxZw=; b=sDifU7u9jNRAq5kNlqnu/1rkZANl6J1APsRXOe4d7bIEp377J8Y7y2w5LrFDcQJSbH lXX4OW5VlRxigCaqjpcukYysnA+fjS1u+Q/fG0wKdvMUulYcSnQxOZc1J/I8nfOePfZu bWXI8CEyUfvCdtKDOMVT+79sIFILkj3WI+0aBnz3mcLoW35/zDQ93x/YKiRL0qXHVxbZ m3qV3PP2fwReCTaK8OGWO3OJPbldUT21fo1e7y5QyOPC3bSPvS+2J/rOVKp6v8g7sLqf 3Gb+Ho+m/xFjU+Xx/pCODD5T+A8uDxISAOWxuej/+XwooJ2yDNYfwOXn/GBI/h02mLy5 mTWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bCbdxxLbqxrpV82n9Yp3CBGNk09BtzYShH1n+PyQxZw=; b=boRfELNp8gOxYZSMGXl89U2rgBToqg0hnpyimB9YYU8sWcbdd8m+b1SBxtu8UG6Jsb MNglM76fTMjzt/MQRaHAdp4xvfmQ5r50WkKcq54qvD2ko4ckeWXIUWDBGe13WxvgIiE7 CdFw8ztvSE0eZlnpcZpA77u9gIMUt/klmpP1mMlllT1n2NzJ3jBAL7CG+v5KjE+30OVg pAJ6k2ALMv/sAiKLHEk+iSSC8LLMDw6RyMm7p1TVpaLBzh5uVLLcttaedfzXyuFZ0a1r jTXpd4ZowPlFF1gwD+4p65Yqvci4o6JKzPsHx9M3fEhJlf0NB0dpPphsX9/NO9yVuqfv 3I0g== X-Gm-Message-State: APjAAAV4VClpGwqxgOZHe9rGeaiQe/38psPPnNepwLhSBn2GvkKIUfmh IG1SJipdi0pgxuzxdACJYrVMA9NU X-Google-Smtp-Source: APXvYqxpuM1LWAHpIrorVL3CbA/q0uiJjOiAgTMu5yGGCSK7GRpI1zv6AkjqptzH0aucfiwlL9Jgdw== X-Received: by 2002:a5d:5452:: with SMTP id w18mr86200966wrv.327.1564480046500; Tue, 30 Jul 2019 02:47:26 -0700 (PDT) Received: from vd-lxpc-hfe.ad.vahle.at ([80.110.31.209]) by smtp.gmail.com with ESMTPSA id r12sm77235777wrt.95.2019.07.30.02.47.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 02:47:25 -0700 (PDT) From: Hubert Feurstein To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hubert Feurstein , Andrew Lunn , Florian Fainelli , Heiner Kallweit , "David S. Miller" Subject: [PATCH] net: phy: fixed_phy: print gpio error only if gpio node is present Date: Tue, 30 Jul 2019 11:46:23 +0200 Message-Id: <20190730094623.31640-1-h.feurstein@gmail.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org It is perfectly ok to not have an gpio attached to the fixed-link node. So the driver should not throw an error message when the gpio is missing. Signed-off-by: Hubert Feurstein --- drivers/net/phy/fixed_phy.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c index 3ffe46df249e..7c5265fd2b94 100644 --- a/drivers/net/phy/fixed_phy.c +++ b/drivers/net/phy/fixed_phy.c @@ -216,8 +216,10 @@ static struct gpio_desc *fixed_phy_get_gpiod(struct device_node *np) if (IS_ERR(gpiod)) { if (PTR_ERR(gpiod) == -EPROBE_DEFER) return gpiod; - pr_err("error getting GPIO for fixed link %pOF, proceed without\n", - fixed_link_node); + + if (PTR_ERR(gpiod) != -ENOENT) + pr_err("error getting GPIO for fixed link %pOF, proceed without\n", + fixed_link_node); gpiod = NULL; } -- 2.22.0