From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 478CEC433FF for ; Tue, 30 Jul 2019 10:11:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CCCF206E0 for ; Tue, 30 Jul 2019 10:11:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mwt+N/rr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732170AbfG3KLv (ORCPT ); Tue, 30 Jul 2019 06:11:51 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44381 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726078AbfG3KLv (ORCPT ); Tue, 30 Jul 2019 06:11:51 -0400 Received: by mail-wr1-f68.google.com with SMTP id p17so65088393wrf.11; Tue, 30 Jul 2019 03:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=naKRDX9WVo3cs2KZ0MRfRmaNOOl0VGQTm099H1LHTFA=; b=mwt+N/rr9IRwMUmgbPph/bv0tW2YVSgPQpf9L7S+qZiQmvzTL3dnLmJtN3f+OCJ61d VR/zcfvsHPbiAY5aA+AJlwbmEh0IEOq6XOZlbP2wHe2G7ZLNmj8NWmH14udho7Xkrk+R 3yxdWv4o4DYc3uHQzzMoonMViKrrfdQ+QQ3Ai98fARpP8HMd9+4OYL7e7U6YqUKnYu35 kgnvWibdWrHw62aOXh6oi1qZ0Px0ZnBeEQl68DKc0rGYiYcfinSt0oDiLa3ls2qs8fvV lINJ1Ezp9L+LLnsFtU6Gy3BYtrYv1Hxl0A3vsgllGoyt69NDF13jzDbIsKmSFyJgYXKo oLdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=naKRDX9WVo3cs2KZ0MRfRmaNOOl0VGQTm099H1LHTFA=; b=IAFDXDTbSOe7N1xXJMOFaHWWKWR8XlQ1CUeCTNnTRYP6RArlP3CE3EThYd5iEEQtoY jvUBWNv53qr6An7xCvLctkMelZhU2ZrzEl6c4mRVZkDeSF66tPshruXXlaUBpY2e5YIU jieStr1FCBBekctmUEetVLVG67mh0qga6qK9O9iDXX4j4tDpZ4GFYMMfIP3iIePMZJFq cRhU8qeJWmOL/66gd99u7MSZXdfaBWoa7zFRj9/RqZBypk4LVc4YRVQe5X5iwVytUeDC 5wzymLk63ugw4yJYrKCEXY1+EP8uuhcGs25knxtNfChY3XoKveyVUiPDdIiyUSOdYwQT rvww== X-Gm-Message-State: APjAAAWwDJ5Igs46MpTXzizh5w/t6Z43gEQgnqthGBge7jt0fKF8sFc+ kiZCYQFx4cVMNyEwnQF6HQguDN00 X-Google-Smtp-Source: APXvYqyOn10wVAdTCy2JJCYfoRBCb0ES9hi12BdNy0eCrTe+b372UObinJPXwZD13x/d3N6nZncwvw== X-Received: by 2002:a05:6000:42:: with SMTP id k2mr6096793wrx.80.1564481508717; Tue, 30 Jul 2019 03:11:48 -0700 (PDT) Received: from vd-lxpc-hfe.ad.vahle.at ([80.110.31.209]) by smtp.gmail.com with ESMTPSA id y24sm47435687wmi.10.2019.07.30.03.11.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 03:11:48 -0700 (PDT) From: Hubert Feurstein To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hubert Feurstein , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" Subject: [PATCH] net: dsa: mv88e6xxx: use link-down-define instead of plain value Date: Tue, 30 Jul 2019 12:11:42 +0200 Message-Id: <20190730101142.548-1-h.feurstein@gmail.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Using the define here makes the code more expressive. Signed-off-by: Hubert Feurstein --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 58e298cc90e0..85638b868d8e 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -430,7 +430,7 @@ int mv88e6xxx_port_setup_mac(struct mv88e6xxx_chip *chip, int port, int link, return 0; /* Port's MAC control must not be changed unless the link is down */ - err = chip->info->ops->port_set_link(chip, port, 0); + err = chip->info->ops->port_set_link(chip, port, LINK_FORCED_DOWN); if (err) return err; -- 2.22.0