From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 365D6C0650F for ; Tue, 30 Jul 2019 14:09:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D14020651 for ; Tue, 30 Jul 2019 14:09:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="wMLq/Rzu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730306AbfG3OJd (ORCPT ); Tue, 30 Jul 2019 10:09:33 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47866 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728769AbfG3OJd (ORCPT ); Tue, 30 Jul 2019 10:09:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lTtE/XJYw6H32/RhxGsmURhaXVkUR39iM2/kEC+BNiA=; b=wMLq/RzuiKa/yz4+tFl8J1cywl BWLMefAow1MDAwfsCqwJefskIwzP90lTewHhinOKKBTWy9tGii1XL6ULTC7WFJrW6DmH9AT6qEWnR qskAG2gz+pGwcfo1CxpzflJi6eP/pVHoJNtA8asDlcTAZ+IPRoGboEbVo+zx08+mcWXc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hsSok-0008AC-4c; Tue, 30 Jul 2019 16:09:30 +0200 Date: Tue, 30 Jul 2019 16:09:30 +0200 From: Andrew Lunn To: Hubert Feurstein Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vivien Didelot , Florian Fainelli , "David S. Miller" Subject: Re: [PATCH 1/2] net: dsa: mv88e6xxx: add support to setup led-control register through device-tree Message-ID: <20190730140930.GM28552@lunn.ch> References: <20190730101451.845-1-h.feurstein@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190730101451.845-1-h.feurstein@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 30, 2019 at 12:14:50PM +0200, Hubert Feurstein wrote: > So it is possible to change the default behaviour of the switch LEDs. Sorry, but this is not going to be accepted. There is an ongoing discussion about PHY LEDs and how they should be configured. Switch LEDs are no different from PHY LEDs. So they should use the same basic concept. Please take a look at the discussion around: [RFC] dt-bindings: net: phy: Add subnode for LED configuration Marvell designers have made this more difficult than it should be by moving the registers out of the PHY address space and into the switch address space. So we are going to have to implement this code twice :-( Andrew