From: Stephen Hemminger <stephen@networkplumber.org>
To: Shannon Nelson <snelson@pensando.io>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH v4 net-next 15/19] ionic: Add netdev-event handling
Date: Tue, 30 Jul 2019 16:39:47 -0700 [thread overview]
Message-ID: <20190730163947.3e730f25@hermes.lan> (raw)
In-Reply-To: <20190722214023.9513-16-snelson@pensando.io>
On Mon, 22 Jul 2019 14:40:19 -0700
Shannon Nelson <snelson@pensando.io> wrote:
> +
> +static void ionic_lif_set_netdev_info(struct lif *lif)
> +{
> + struct ionic_admin_ctx ctx = {
> + .work = COMPLETION_INITIALIZER_ONSTACK(ctx.work),
> + .cmd.lif_setattr = {
> + .opcode = CMD_OPCODE_LIF_SETATTR,
> + .index = cpu_to_le16(lif->index),
> + .attr = IONIC_LIF_ATTR_NAME,
> + },
> + };
> +
> + strlcpy(ctx.cmd.lif_setattr.name, lif->netdev->name,
> + sizeof(ctx.cmd.lif_setattr.name));
> +
> + dev_info(lif->ionic->dev, "NETDEV_CHANGENAME %s %s\n",
> + lif->name, ctx.cmd.lif_setattr.name);
> +
There is already a kernel message for this. Repeating the same thing in the
driver is redundant.
next prev parent reply other threads:[~2019-07-30 23:39 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 21:40 [PATCH v4 net-next 00/19] Add ionic driver Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 01/19] ionic: Add basic framework for IONIC Network device driver Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 02/19] ionic: Add hardware init and device commands Shannon Nelson
2019-07-23 21:18 ` David Miller
2019-07-23 22:50 ` Shannon Nelson
2019-07-23 23:05 ` David Miller
2019-07-23 23:23 ` Shannon Nelson
2019-07-24 17:49 ` Shannon Nelson
2019-07-24 20:07 ` David Miller
2019-07-23 23:47 ` Saeed Mahameed
2019-07-24 0:25 ` Shannon Nelson
2019-07-24 20:23 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 03/19] ionic: Add port management commands Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 04/19] ionic: Add basic lif support Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 05/19] ionic: Add interrupts and doorbells Shannon Nelson
2019-07-23 21:24 ` David Miller
2019-07-23 22:50 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 06/19] ionic: Add basic adminq support Shannon Nelson
2019-07-23 21:27 ` David Miller
2019-07-23 22:50 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 07/19] ionic: Add adminq action Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 08/19] ionic: Add notifyq support Shannon Nelson
2019-07-24 23:21 ` Saeed Mahameed
2019-07-30 18:35 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 09/19] ionic: Add the basic NDO callbacks for netdev support Shannon Nelson
2019-07-24 23:45 ` Saeed Mahameed
2019-07-30 18:35 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 10/19] ionic: Add management of rx filters Shannon Nelson
2019-07-24 23:52 ` Saeed Mahameed
2019-07-22 21:40 ` [PATCH v4 net-next 11/19] ionic: Add Rx filter and rx_mode ndo support Shannon Nelson
2019-07-23 21:33 ` David Miller
2019-07-23 22:50 ` Shannon Nelson
2019-07-23 23:06 ` David Miller
2019-07-23 23:54 ` Saeed Mahameed
2019-07-24 0:19 ` Shannon Nelson
2019-07-24 0:19 ` Shannon Nelson
2019-07-23 22:51 ` Saeed Mahameed
2019-07-23 23:20 ` Saeed Mahameed
2019-07-24 0:07 ` Shannon Nelson
2019-07-24 21:10 ` Saeed Mahameed
2019-07-22 21:40 ` [PATCH v4 net-next 12/19] ionic: Add async link status check and basic stats Shannon Nelson
2019-07-25 0:04 ` Saeed Mahameed
2019-07-30 18:35 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 13/19] ionic: Add initial ethtool support Shannon Nelson
2019-07-23 21:35 ` David Miller
2019-07-23 22:50 ` Shannon Nelson
2019-07-25 0:17 ` Saeed Mahameed
2019-07-30 18:57 ` Shannon Nelson
2019-07-25 13:28 ` Andrew Lunn
2019-07-25 13:35 ` Andrew Lunn
2019-07-30 21:51 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 14/19] ionic: Add Tx and Rx handling Shannon Nelson
2019-07-23 21:36 ` David Miller
2019-07-25 23:48 ` Saeed Mahameed
2019-08-09 22:27 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 15/19] ionic: Add netdev-event handling Shannon Nelson
2019-07-25 23:55 ` Saeed Mahameed
2019-07-30 22:53 ` Shannon Nelson
2019-07-30 23:39 ` Stephen Hemminger [this message]
2019-07-31 1:10 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 16/19] ionic: Add driver stats Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 17/19] ionic: Add RSS support Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 18/19] ionic: Add coalesce and other features Shannon Nelson
2019-07-23 21:40 ` David Miller
2019-07-26 0:13 ` Saeed Mahameed
2019-08-02 21:48 ` Shannon Nelson
2019-07-22 21:40 ` [PATCH v4 net-next 19/19] ionic: Add basic devlink interface Shannon Nelson
2019-07-23 21:40 ` David Miller
2019-07-23 22:50 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730163947.3e730f25@hermes.lan \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).