From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0299AC32751 for ; Wed, 31 Jul 2019 20:58:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C20E52067D for ; Wed, 31 Jul 2019 20:58:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730702AbfGaU6p (ORCPT ); Wed, 31 Jul 2019 16:58:45 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:45646 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726417AbfGaU6p (ORCPT ); Wed, 31 Jul 2019 16:58:45 -0400 Received: from cpe-2606-a000-111b-6140-0-0-0-162e.dyn6.twc.com ([2606:a000:111b:6140::162e] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1hsvg9-0007ME-TG; Wed, 31 Jul 2019 16:58:40 -0400 Date: Wed, 31 Jul 2019 16:58:04 -0400 From: Neil Horman To: Joe Perches Cc: Vlad Yasevich , Marcelo Ricardo Leitner , "David S. Miller" , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sctp: Rename fallthrough label to unhandled Message-ID: <20190731205804.GE9823@hmswarspite.think-freely.org> References: <20190731111932.GA9823@hmswarspite.think-freely.org> <20190731121646.GD9823@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jul 31, 2019 at 09:35:31AM -0700, Joe Perches wrote: > On Wed, 2019-07-31 at 08:16 -0400, Neil Horman wrote: > > On Wed, Jul 31, 2019 at 04:32:43AM -0700, Joe Perches wrote: > > > On Wed, 2019-07-31 at 07:19 -0400, Neil Horman wrote: > > > > On Tue, Jul 30, 2019 at 10:04:37PM -0700, Joe Perches wrote: > > > > > fallthrough may become a pseudo reserved keyword so this only use of > > > > > fallthrough is better renamed to allow it. > > > > > > > > > > Signed-off-by: Joe Perches > > > > Are you referring to the __attribute__((fallthrough)) statement that gcc > > > > supports? If so the compiler should by all rights be able to differentiate > > > > between a null statement attribute and a explicit goto and label without the > > > > need for renaming here. Or are you referring to something else? > > > > > > Hi. > > > > > > I sent after this a patch that adds > > > > > > # define fallthrough __attribute__((__fallthrough__)) > > > > > > https://lore.kernel.org/patchwork/patch/1108577/ > > > > > > So this rename is a prerequisite to adding this #define. > > > > > why not just define __fallthrough instead, like we do for all the other > > attributes we alias (i.e. __read_mostly, __protected_by, __unused, __exception, > > etc) > > Because it's not as intelligible when used as a statement. I think thats somewhat debatable. __fallthrough to me looks like an internal macro, whereas fallthrough looks like a comment someone forgot to /* */ Neil > > > >