From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 910E5C19759 for ; Thu, 1 Aug 2019 21:04:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F59E20838 for ; Thu, 1 Aug 2019 21:04:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389047AbfHAVEJ (ORCPT ); Thu, 1 Aug 2019 17:04:09 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:32830 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725846AbfHAVEJ (ORCPT ); Thu, 1 Aug 2019 17:04:09 -0400 Received: from localhost (c-24-20-22-31.hsd1.or.comcast.net [24.20.22.31]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 360411540AD55; Thu, 1 Aug 2019 14:04:08 -0700 (PDT) Date: Thu, 01 Aug 2019 17:04:07 -0400 (EDT) Message-Id: <20190801.170407.2164489969623955445.davem@davemloft.net> To: mka@chromium.org Cc: robh+dt@kernel.org, mark.rutland@arm.com, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org Subject: Re: [PATCH v4 4/4] net: phy: realtek: configure RTL8211E LEDs From: David Miller In-Reply-To: <20190801190759.28201-5-mka@chromium.org> References: <20190801190759.28201-1-mka@chromium.org> <20190801190759.28201-5-mka@chromium.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 01 Aug 2019 14:04:08 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Matthias Kaehlcke Date: Thu, 1 Aug 2019 12:07:59 -0700 > +static int rtl8211e_config_leds(struct phy_device *phydev) > +{ > + int i, oldpage, ret; > + u16 lacr_bits = 0, lcr_bits = 0; > + u16 lacr_mask = RLT8211E_LACR_LEDACTCTRL_MASK; > + u16 lcr_mask = RTL8211E_LCR_LEDCTRL_MASK; > + bool eed_led_mode_disabled = false; Please use reverse christmas tree ordering here.