From: Stephen Hemminger <stephen@networkplumber.org>
To: jiri@resnulli.us, chrism@mellanox.com
Cc: netdev@vger.kernel.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: [RFC iproute2 0/4] Revert tc batchsize feature
Date: Wed, 31 Jul 2019 17:45:02 -0700 [thread overview]
Message-ID: <20190801004506.9049-1-stephen@networkplumber.org> (raw)
The batchsize feature of tc might save a few cycles but it
is a maintaince nightmare, it has uninitialized variables and
poor error handling.
This patch set reverts back to the original state.
Please don't resubmit original code. Go back to the drawing
board and do something generic. For example, the routing
daemons have figured out that by using multiple threads and
turning off the netlink ACK they can update millions of routes
quickly.
Stephen Hemminger (4):
Revert "tc: Remove pointless assignments in batch()"
Revert "tc: flush after each command in batch mode"
Revert "tc: fix batch force option"
Revert "tc: Add batchsize feature for filter and actions"
tc/m_action.c | 65 ++++++----------
tc/tc.c | 201 ++++---------------------------------------------
tc/tc_common.h | 7 +-
tc/tc_filter.c | 129 ++++++++++++-------------------
4 files changed, 87 insertions(+), 315 deletions(-)
next reply other threads:[~2019-08-01 0:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 0:45 Stephen Hemminger [this message]
2019-08-01 0:45 ` [RFC iproute2 1/4] Revert "tc: Remove pointless assignments in batch()" Stephen Hemminger
2019-08-01 0:45 ` [RFC iproute2 2/4] Revert "tc: flush after each command in batch mode" Stephen Hemminger
2019-08-01 0:45 ` [RFC iproute2 3/4] Revert "tc: fix batch force option" Stephen Hemminger
2019-08-01 0:45 ` [RFC iproute2 4/4] Revert "tc: Add batchsize feature for filter and actions" Stephen Hemminger
2019-08-01 1:11 ` [RFC iproute2 0/4] Revert tc batchsize feature Dave Taht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801004506.9049-1-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=chrism@mellanox.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).